Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lvgl port sw rotation #355

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Feat/lvgl port sw rotation #355

merged 1 commit into from
Aug 6, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Jul 26, 2024 •
edited
Loading

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing

Change description

  • Enabled SW rotation in LVGL port (LVGL9)
  • Improved initialization of LVGL for using with OS (for more drawable units)
  • Fixed bad handled touch due to synchronization timer task

Closes #351

@espzav espzav force-pushed the feat/lvgl_port_sw_rotation branch 3 times, most recently from 0f980d3 to 943a926 Compare July 26, 2024 13:39
@espzav espzav mentioned this pull request Jul 26, 2024
Closed
1 task
@espzav
Copy link
Collaborator Author

espzav commented Jul 30, 2024

@tore-espressif PTAL

tore-espressif
tore-espressif reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a WIP review with few questions. I'd like to test the rotation on HW :)

bsp/esp32_p4_function_ev_board/esp32_p4_function_ev_board.c Show resolved Hide resolved
examples/display_lvgl_demos/main/CMakeLists.txt Outdated Show resolved Hide resolved
components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c Show resolved Hide resolved
tore-espressif
tore-espressif reviewed Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espzav Overall LGTM. When I tried the display_rotation on our latest P4 devkit, it did not work correctly with RGB888 color width. Rotations 90 and 270 deg produced slightly broken screen

@espzav espzav force-pushed the feat/lvgl_port_sw_rotation branch from 943a926 to 2257c11 Compare August 2, 2024 08:40
@espzav
Copy link
Collaborator Author

espzav commented Aug 6, 2024

@espzav Overall LGTM. When I tried the display_rotation on our latest P4 devkit, it did not work correctly with RGB888 color width. Rotations 90 and 270 deg produced slightly broken screen

@tore-espressif
It will be fixed in LVGL: lvgl/lvgl#6642
Can we merge this PR now?

@espzav espzav force-pushed the feat/lvgl_port_sw_rotation branch from 2257c11 to 4ffc076 Compare August 6, 2024 06:45
@espzav espzav merged commit 97d9dd9 into master Aug 6, 2024
41 checks passed
@espzav espzav deleted the feat/lvgl_port_sw_rotation branch August 6, 2024 11:56
@liamHowatt liamHowatt mentioned this pull request Aug 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GT911 uses interrupt mode, and most single touches on LVGL are equivalent to two touches. (BSP-523)
2 participants
@espzav @tore-espressif