Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lcd): Modified the ILI9881 and ST7796 LCD component (BSP-529) #359

Merged

Conversation

Horion0415
Copy link
Contributor

@Horion0415 Horion0415 commented Aug 7, 2024

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

Please describe your change here

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title feat(lcd): Modified the ILI9881 and ST7796 LCD component feat(lcd): Modified the ILI9881 and ST7796 LCD component (BSP-529) Aug 7, 2024
@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 12 times, most recently from 23b1300 to 1ebcb79 Compare August 12, 2024 01:44
@espzav
Copy link
Collaborator

espzav commented Aug 13, 2024

@Horion0415 Thank you for changes in LCD drivers. Is it ready for review now?
Please, rebase master for pass tests.

@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 2 times, most recently from 6a53d7d to 3bb3f25 Compare August 13, 2024 12:38
@Horion0415
Copy link
Contributor Author

Yes, it is ready now. Thank you for your review.

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Horion0415 Thank you for this PR. I tested on HW only ILI9881C, because I haven't got HW for ST7769.
I left one comment - how to use ST7769 with MIPI, I80 and SPI?

components/lcd/esp_lcd_st7796/esp_lcd_st7796.c Outdated Show resolved Hide resolved
@Horion0415
Copy link
Contributor Author

Hi, @espzav could you please help resolve the CI issue? It's been giving me a headache. I noticed that the CI for this repository doesn’t always run, which makes it hard for me to know if my changes have passed the CI in time. The esp_lcd_ili9881c component didn’t have a test case before, but after I added a new test case, I found that the CI sets the target to a chip other than ESP32-P4, causing the CI to fail. I've added the corresponding rules in .build-test-rules.yml, but it still hasn't taken effect.

@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 2 times, most recently from 47b7574 to ccf1c59 Compare August 15, 2024 04:36
.build-test-rules.yml Outdated Show resolved Hide resolved
@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 5 times, most recently from f706834 to dbcc821 Compare August 17, 2024 05:30
@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 2 times, most recently from 501a740 to 2f77845 Compare August 17, 2024 05:44
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Horion0415 Thank you. LGTM

Copy link
Collaborator

@suda-morris suda-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks for the refactor @Horion0415

@Horion0415 Horion0415 force-pushed the feat/ili9881_component_mod branch 2 times, most recently from a1a83ef to caea955 Compare August 30, 2024 04:44
@tore-espressif tore-espressif merged commit a7de01b into espressif:master Aug 30, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants