-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lcd): Modified the ILI9881 and ST7796 LCD component (BSP-529) #359
feat(lcd): Modified the ILI9881 and ST7796 LCD component (BSP-529) #359
Conversation
23b1300
to
1ebcb79
Compare
@Horion0415 Thank you for changes in LCD drivers. Is it ready for review now? |
6a53d7d
to
3bb3f25
Compare
Yes, it is ready now. Thank you for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Horion0415 Thank you for this PR. I tested on HW only ILI9881C, because I haven't got HW for ST7769.
I left one comment - how to use ST7769 with MIPI, I80 and SPI?
3bb3f25
to
c399c33
Compare
Hi, @espzav could you please help resolve the CI issue? It's been giving me a headache. I noticed that the CI for this repository doesn’t always run, which makes it hard for me to know if my changes have passed the CI in time. The |
47b7574
to
ccf1c59
Compare
f706834
to
dbcc821
Compare
501a740
to
2f77845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Horion0415 Thank you. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks for the refactor @Horion0415
a1a83ef
to
caea955
Compare
caea955
to
5c83d21
Compare
ESP-BSP Pull Request checklist
Change description
Please describe your change here