Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qma6100p accelerometer #375

Merged
merged 1 commit into from
Oct 3, 2024
Merged

add qma6100p accelerometer #375

merged 1 commit into from
Oct 3, 2024

Conversation

pborcin
Copy link
Collaborator

@pborcin pborcin commented Aug 20, 2024 •
edited by tore-espressif
Loading

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • New BSP definitions added to bsp_ext.py
  • BSP was added to SquareLine
  • New BSP supports IDF v4.4.x and later releases
  • Optional: Component contains unit tests
  • CI passing

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pborcin pborcin marked this pull request as draft August 20, 2024 12:57
@pborcin pborcin force-pushed the feat/qma6100p branch 3 times, most recently from 2e06e91 to 02760a3 Compare September 9, 2024 07:45
@pborcin pborcin marked this pull request as ready for review September 9, 2024 08:22
@pborcin pborcin force-pushed the feat/qma6100p branch 3 times, most recently from b528514 to 1b24d14 Compare September 9, 2024 11:16
@pborcin
Copy link
Collaborator Author

pborcin commented Sep 9, 2024

@tore-espressif @espzav PTAL

tore-espressif
tore-espressif reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pborcin I quickly went through the code and added some comments.

The code and API overall looks very good! I'll test on HW, once I get the new S3-EYE with QMA6100!

bsp/esp32_s3_eye/idf_component.yml Outdated Show resolved Hide resolved
bsp/esp32_s3_eye/idf_component.yml Show resolved Hide resolved
components/qma6100p/README.md Outdated Show resolved Hide resolved
components/qma6100p/test/qma6100p_test.c Outdated Show resolved Hide resolved
components/qma6100p/qma6100p.c Show resolved Hide resolved
components/qma6100p/include/qma6100p.h Outdated Show resolved Hide resolved
components/qma6100p/test/qma6100p_test.c Outdated Show resolved Hide resolved
components/qma6100p/test/CMakeLists.txt Outdated Show resolved Hide resolved
@tore-espressif
Copy link
Collaborator

@pborcin LGTM, but it seems that this step is still missing
image

(I'm sorry, I've also rebased your branch, so please update your local branch too)

@tore-espressif tore-espressif merged commit 0a83a89 into espressif:master Oct 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pborcin @CLAassistant @tore-espressif