Added example for the DS18B20 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
igrr
reviewed
Sep 23, 2024
igrr
reviewed
Sep 25, 2024
There was a problem hiding this comment.
LGTM!
To fix the build issue, I think you need to add a rule in .build-test-rules.yml to only build the example if the chip has RMT:
components/ds18b20:
disable:
- if: SOC_RMT_SUPPORTED != 1
reason: Onewire component depends on RMT peripheraland please clean up commit history before merging.
pedrominatel
force-pushed
the
add-example-ds18b20
branch
from
1ef8bde
to
9cb86de
Compare
Can you kindly take a look, @tore-espressif? Many thanks! |
Added YML file and license Update components/ds18b20/examples/ds18b20-read/CMakeLists.txt Co-authored-by: Ivan Grokhotkov <[email protected]> Update components/ds18b20/examples/ds18b20-read/README.md Co-authored-by: Ivan Grokhotkov <[email protected]> Update components/ds18b20/examples/ds18b20-read/main/ds18b20-read.c Co-authored-by: Ivan Grokhotkov <[email protected]> Update components/ds18b20/examples/ds18b20-read/main/ds18b20-read.c Co-authored-by: Ivan Grokhotkov <[email protected]> Update components/ds18b20/examples/ds18b20-read/main/ds18b20-read.c Co-authored-by: Ivan Grokhotkov <[email protected]> README file updated Code review/renaming and static vars fixed Added RMT skip as a build test rule
tore-espressif
force-pushed
the
add-example-ds18b20
branch
from
9cb86de
to
a3405b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
This PR adds a simple example of how to read the DS18B20. This example was used during a presentation to show how to use the components and BSP.