feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) #409

ThunderDai · 2024-10-15T04:03:18Z

  Mainly supports the following features:
   - color blend (simple fill)
   - color blend with opa 
   - blend normal (blend with argb8888) 
   - blend normal (color convert / memcpy)

CLAassistant · 2024-10-15T04:03:24Z

All committers have signed the CLA.

ThunderDai · 2024-10-16T01:59:34Z

@peter-marcisovsky @espzav hi, PTAL, this is my first commit for esp-bsp. Therefore, some code related rules are not familiar enough

peter-marcisovsky

Could you consider adding some tests to your feature? If you take a look at my #357 , there are functionality and benchmark unit tests. Would it be possible to do the same for this feature?

Also, can you take a look at the failing CI?

peter-marcisovsky · 2024-10-17T14:44:19Z

components/esp_lvgl_port/include/esp_lvgl_port_lv_blend.h

@@ -55,6 +55,21 @@ typedef struct {

 extern int lv_color_blend_to_argb8888_esp(asm_dsc_t *asm_dsc);

+// Just for compatibility with v9.2.0


I would not recommend this approach of solving compatibility issues with LVGL 9.2.
I tried to build lvlgl_port test app on your branch, with the HW accelerating enabled and the test app would not build, neither with LVGL9.1, nor with LVGL9.2.

peter@peter ➜ ~/esp/esp-bsp/components/esp_lvgl_port/test_apps/lvgl_port git:(pr/409) ✗ idf.py -DSDKCONFIG_DEFAULTS='sdkconfig.defaults;sdkconfig.ci.asm_render' set-target esp32s3 build

Is your feature working with LVGL9.1? If yes, could you consider using just LVGL9.1 in this MR?

We have agreed to make the HW acceleration support working with LVGL9.1, for now here, until we figure out what to do with this brekaing changes which was introduced in LVGL9.2.

ThunderDai · 2024-10-18T01:08:35Z

Could you consider adding some tests to your feature? If you take a look at my #357 , there are functionality and benchmark unit tests. Would it be possible to do the same for this feature?

Also, can you take a look at the failing CI?

yes, can add some test. I have already included the newly submitted lvgl_port component as part of my project and have run the benchmark without any issues. I will also try running the existing test_apps. It is worth noting that because PPA has implemented some of your current functions, it conflicts with the current header file. I have added a new header file myself. The following configuration is required:

CONFIG_LV_DRAW_SW_ASM_CUSTOM=y
CONFIG_LV_DRAW_SW_ASM_CUSTOM_INCLUDE="esp_lvgl_port_lv_blend_ppa.h"
CONFIG_LV_USE_CUSTOM_MALLOC=y

Mainly supports the following features: - color blend (simple fill) - color blend with opa - blend normal (blend with argb8888) - blend normal to color (color convert / memcpy)

tore-espressif

@ThunderDai I'm sorry for the late start of review. I left few comments for start

tore-espressif · 2024-11-15T10:21:50Z

components/esp_lvgl_port/examples/mipi_dsi/main/idf_component.yml

+  espressif/esp32_p4_function_ev_board:
+    version: "*"
+    override_path: "../../../../../bsp/esp32_p4_function_ev_board"


For esp_lvgl_port, we try to avoid dependencies on any BSP. Can we removed it?

If not, we can place the example in different location,(not directly into esp_lvgl_port component)

tore-espressif · 2024-11-15T12:47:28Z

components/esp_lvgl_port/src/lvgl9/esp_lvgl_port_disp.c

@@ -286,7 +296,11 @@ static lv_display_t *lvgl_port_add_disp_priv(const lvgl_port_display_cfg_t *disp
        buff_caps |= MALLOC_CAP_DEFAULT;
    }

-    /* Use RGB internal buffers for avoid tearing effect */
+#if CONFIG_IDF_TARGET_ESP32P4


Suggested change

#if CONFIG_IDF_TARGET_ESP32P4

#if SOC_CACHE_INTERNAL_MEM_VIA_L1CACHE

Would this be better for forward compatibility?

tore-espressif · 2024-11-15T12:48:04Z

components/esp_lvgl_port/src/lvgl9/esp_lvgl_port_disp.c

-        if (buf1) {
-            free(buf1);
+        if (disp_ctx->draw_buffs[0]) {
+            free(disp_ctx->draw_buffs[0]);
        }
-        if (buf2) {
-            free(buf2);
+        if (disp_ctx->draw_buffs[1]) {
+            free(disp_ctx->draw_buffs[1]);


Thank you for this fix! It was already fixed in the master branch, so you might have to resolve some conflicts...

tore-espressif · 2024-11-15T12:50:14Z

components/esp_lvgl_port/CMakeLists.txt

@@ -77,12 +77,12 @@ if("usb_host_hid" IN_LIST build_components)
 endif()

 # Include SIMD assembly source code for rendering, only for (9.1.0 <= LVG_version < 9.2.0) and only for esp32 and esp32s3
-if((lvgl_ver VERSION_GREATER_EQUAL "9.1.0") AND (lvgl_ver VERSION_LESS "9.2.0"))
-    if(CONFIG_IDF_TARGET_ESP32 OR CONFIG_IDF_TARGET_ESP32S3)
+if((lvgl_ver VERSION_GREATER_EQUAL "9.1.0") AND (lvgl_ver VERSION_LESS_EQUAL "9.2.0"))


Does it really work with 9.2.0? we had some compatibility problems with this version. If yes, why can't support 9.2.2 too?

tore-espressif · 2024-11-18T14:28:24Z

components/esp_lvgl_port/test_apps/simd/main/lv_blend/include/lv_version.h

+#define LVGL_VERSION_MAJOR 9
+#define LVGL_VERSION_MINOR 1
+#define LVGL_VERSION_PATCH 0
+#define LVGL_VERSION_INFO ""


Why can't we use lv_version.h from the lvgl component?

tore-espressif · 2024-11-22T08:00:53Z

components/esp_lvgl_port/src/lvgl9/ppa/bsp_dma2d.c

+    dma2d_descriptor_t *tx_link_buffer = (dma2d_descriptor_t *)heap_caps_aligned_calloc(64, 1, 64, MALLOC_CAP_SPIRAM);
+    dma2d_descriptor_t *rx_link_buffer = (dma2d_descriptor_t *)heap_caps_aligned_calloc(64, 1, 64, MALLOC_CAP_SPIRAM);


The cache line size is configurable. Can be 64 or 128. Can we take the value from sdkconfig.h?

tore-espressif · 2024-11-22T08:01:48Z

components/esp_lvgl_port/src/lvgl9/ppa/bsp_dma2d.c

+    esp_cache_msync((void *)tx_dsc, 64, ESP_CACHE_MSYNC_FLAG_DIR_C2M | ESP_CACHE_MSYNC_FLAG_UNALIGNED);
+    esp_cache_msync((void *)rx_dsc, 64, ESP_CACHE_MSYNC_FLAG_DIR_C2M | ESP_CACHE_MSYNC_FLAG_UNALIGNED);


Same here, you assume cache line size == 64. But it can be 128 too.

Is the unaligned sync sage here? If yes, please provide better comment

github-actions bot changed the title ~~feature(lvgl_port): Initial support for ppa rendering in lvgl~~ feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) Oct 15, 2024

ThunderDai force-pushed the feat/add_ppa_for_lvgl_render branch from 0984d25 to 9723801 Compare October 15, 2024 06:26

ThunderDai marked this pull request as draft October 15, 2024 06:44

ThunderDai marked this pull request as ready for review October 15, 2024 07:34

peter-marcisovsky reviewed Oct 17, 2024

View reviewed changes

ThunderDai marked this pull request as draft October 21, 2024 08:47

ThunderDai force-pushed the feat/add_ppa_for_lvgl_render branch 2 times, most recently from 24e762a to 0b1609e Compare October 24, 2024 02:24

ThunderDai marked this pull request as ready for review October 24, 2024 02:26

ThunderDai force-pushed the feat/add_ppa_for_lvgl_render branch 5 times, most recently from 865eada to 461a0f8 Compare October 28, 2024 03:07

feat(lvgl_port): Initial support for ppa rendering in lvgl

47b925e

Mainly supports the following features: - color blend (simple fill) - color blend with opa - blend normal (blend with argb8888) - blend normal to color (color convert / memcpy)

ThunderDai force-pushed the feat/add_ppa_for_lvgl_render branch from 461a0f8 to 47b925e Compare October 28, 2024 06:32

tore-espressif reviewed Nov 15, 2024

View reviewed changes

tore-espressif reviewed Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) #409

feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) #409

ThunderDai commented Oct 15, 2024

CLAassistant commented Oct 15, 2024 •

edited

Loading

ThunderDai commented Oct 16, 2024

peter-marcisovsky left a comment •

edited

Loading

peter-marcisovsky Oct 17, 2024

ThunderDai commented Oct 18, 2024

tore-espressif left a comment

tore-espressif Nov 15, 2024

tore-espressif Nov 15, 2024

tore-espressif Nov 15, 2024

tore-espressif Nov 15, 2024

tore-espressif Nov 18, 2024

tore-espressif Nov 22, 2024

tore-espressif Nov 22, 2024

		@@ -55,6 +55,21 @@ typedef struct {

		extern int lv_color_blend_to_argb8888_esp(asm_dsc_t *asm_dsc);

		// Just for compatibility with v9.2.0

	#if CONFIG_IDF_TARGET_ESP32P4
	#if SOC_CACHE_INTERNAL_MEM_VIA_L1CACHE

		dma2d_descriptor_t tx_link_buffer = (dma2d_descriptor_t )heap_caps_aligned_calloc(64, 1, 64, MALLOC_CAP_SPIRAM);
		dma2d_descriptor_t rx_link_buffer = (dma2d_descriptor_t )heap_caps_aligned_calloc(64, 1, 64, MALLOC_CAP_SPIRAM);

		esp_cache_msync((void *)tx_dsc, 64, ESP_CACHE_MSYNC_FLAG_DIR_C2M \| ESP_CACHE_MSYNC_FLAG_UNALIGNED);
		esp_cache_msync((void *)rx_dsc, 64, ESP_CACHE_MSYNC_FLAG_DIR_C2M \| ESP_CACHE_MSYNC_FLAG_UNALIGNED);

feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) #409

Are you sure you want to change the base?

feature(lvgl_port): Initial support for ppa rendering in lvgl (BSP-563) #409

Conversation

ThunderDai commented Oct 15, 2024

CLAassistant commented Oct 15, 2024 • edited Loading

ThunderDai commented Oct 16, 2024

peter-marcisovsky left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ThunderDai commented Oct 18, 2024

tore-espressif left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Oct 15, 2024 •

edited

Loading

peter-marcisovsky left a comment •

edited

Loading