refactor(io_expander): support i2c ng #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lzw655
force-pushed
the
refactor/io_expander_i2c_ng
branch
from
b1a2c1e
to
fbcb670
Compare
|
Hi @tore-espressif @espzav, PTAL, thank you! |
This was referenced Oct 29, 2024
tore-espressif
force-pushed
the
refactor/io_expander_i2c_ng
branch
from
fbcb670
to
480eb27
Compare
|
@Lzw655 I rebased your branch so it gets some fixes from master. I'll have a look ASAP, thank you! |
tore-espressif
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
LGTM @Lzw655 ! I left few nitpick comments and 1 important about I2C commands timeout
components/io_expander/esp_io_expander_tca95xx_16bit/test_apps/CMakeLists.txt
Outdated
Show resolved
Hide resolved
components/io_expander/esp_io_expander_ht8574/esp_io_expander_ht8574.c
Outdated
Show resolved
Hide resolved
Lzw655
force-pushed
the
refactor/io_expander_i2c_ng
branch
from
480eb27
to
e6214dc
Compare
|
@tore-espressif Thank you for reviewing! All fixed. |
components/io_expander/esp_io_expander_ht8574/esp_io_expander_ht8574.c
Outdated
Show resolved
Hide resolved
@Lzw655 Thank you for the quick update, I have one last comment and we can merge |
Lzw655
force-pushed
the
refactor/io_expander_i2c_ng
branch
from
e6214dc
to
0377604
Compare
tore-espressif
force-pushed
the
refactor/io_expander_i2c_ng
branch
from
0377604
to
93d0694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Closes #402
Change description
Please describe your change here