Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update image loading method (BSP-577) #428

Conversation

espressif2022
Copy link
Contributor

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  • Preprocess and load images using esp_mmap_assets and esp_lv_fs
-        lv_img_set_src(img_text, &esp_text);
+        lv_img_set_src(img_text, "A:esp_text.bin");

@github-actions github-actions bot changed the title feat: Update image loading method feat: Update image loading method (BSP-577) Nov 1, 2024
@igrr
Copy link
Member

igrr commented Nov 12, 2024

It is a nice feature, however I don't think it's necessary to use it in BSP examples. The main purpose of BSP examples is to show how to use BSP APIs. They aren't intended to showcase every other possible component which can be used in conjunction with the BSP. At the same time, the fewer dependencies BSPs and BSP examples have, the less often we face issues with build failures or other incompatibilities.

@espressif2022
Copy link
Contributor Author

It is a nice feature, however I don't think it's necessary to use it in BSP examples. The main purpose of BSP examples is to show how to use BSP APIs. They aren't intended to showcase every other possible component which can be used in conjunction with the BSP. At the same time, the fewer dependencies BSPs and BSP examples have, the less often we face issues with build failures or other incompatibilities.

OK, I thought more users would notice this if I put it here, but it does increase the dependency complexity of BSP. This is a good suggestion, I'll close it.

@igrr
Copy link
Member

igrr commented Nov 13, 2024

Yeah, we could perhaps make a separate repository like esp-lvgl-best-practices-app which will show... all the best practices for developing an LVGL-based application for ESP chips. Which might also include the assets-related components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants