Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude installation of top-level test directory (IDFGH-12969) #7

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

stkw0
Copy link
Contributor

@stkw0 stkw0 commented Jun 6, 2024

Previously, test directory was installed at top-level in site-pacakges (e.g: /usr/lib/python3.12/site-packages/test). This patch excludes the test directory from installing in the first place.

Copy link

github-actions bot commented Jun 6, 2024

Messages
📖 Good Job! All checks are passing!

👋 Welcome stkw0, thank you for your first contribution to espressif/esp-idf-kconfig project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

Generated by 🚫 dangerJS against 11d675a

@stkw0 stkw0 changed the title exclude top-level test directory exclude installation of top-level test directory Jun 6, 2024
@dobairoland dobairoland changed the title exclude installation of top-level test directory exclude installation of top-level test directory Jun 6, 2024
@dobairoland dobairoland changed the title exclude installation of top-level test directory exclude installation of top-level test directory Jun 6, 2024
@github-actions github-actions bot changed the title exclude installation of top-level test directory exclude installation of top-level test directory (IDFGH-12969) Jun 6, 2024
Copy link
Collaborator

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIx LGTM, thank you!

Can you please update the commit message to follow the Conventional commit style (last point in the readme)?

I would suggest something like: change: exclude installation of top-level test directory. You can check if the commit message complies with the convention by running pre-commit.

@stkw0
Copy link
Contributor Author

stkw0 commented Jun 7, 2024

Sorry. It was such a small change, I overlooked that part. I fixed it now and pre-commit ran successfully without any complains

@Honza0297
Copy link
Collaborator

LGTM as well.
Thanks for the contribution!

@espressif-bot espressif-bot merged commit 8ce1c4d into espressif:master Jun 10, 2024
2 checks passed
@espressif-bot espressif-bot added Resolution: NA and removed Status: Selected for Development Issue is selected for development labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants