-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude installation of top-level test directory (IDFGH-12969) #7
Conversation
👋 Welcome stkw0, thank you for your first contribution to 📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics. Pull request review and merge process you can expectWe do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIx LGTM, thank you!
Can you please update the commit message to follow the Conventional commit style (last point in the readme)?
I would suggest something like: change: exclude installation of top-level test directory
. You can check if the commit message complies with the convention by running pre-commit.
Sorry. It was such a small change, I overlooked that part. I fixed it now and pre-commit ran successfully without any complains |
LGTM as well. |
Previously, test directory was installed at top-level in site-pacakges (e.g: /usr/lib/python3.12/site-packages/test). This patch excludes the test directory from installing in the first place.