Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp-tls): Remove useless const from size paramter (IDFGH-14099) #14909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0xFEEDC0DE64
Copy link
Contributor

Get rid of useless const from size parameter as it does not allow for easy setup of the struct

Copy link

github-actions bot commented Nov 19, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello 0xFEEDC0DE64, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 4bbff34

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 19, 2024
@github-actions github-actions bot changed the title fix(esp-tls): Remove useless const from size paramter fix(esp-tls): Remove useless const from size paramter (IDFGH-14099) Nov 19, 2024
@0xFEEDC0DE64 0xFEEDC0DE64 force-pushed the remove-useless-const-from-psk-struct branch from f3afd06 to 4bbff34 Compare November 19, 2024 17:21
@AdityaHPatwardhan
Copy link
Collaborator

Hi @0xFEEDC0DE64, The parameter has been marked as const to indicate that the function does not intend to update the value of the parameter in any case. Also, it would be considered as a breaking change now if we are to modify the type.
May I know what problem is it causing at your side?
Is it possible for you to typecast it to const at the time of initialising the config structure if your code is not defining it as a const variable?

@0xFEEDC0DE64
Copy link
Contributor Author

I just need to be able to build that struct from c++ code without having all the data already available on construction.

Please never make any class members const as this breaks anything like copy constructors and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants