fix(xclk): Zero init ledc_channel_config_t for forward compatibility #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LEDC driver was extended in espressif/esp-idf@4a90deb with new config structure members. We must zero init the config struct to get default behavior.
|
@me-no-dev PTAL! It would be good to release new esp32-camare soon, as it does not work with latest esp-idf master on S2 |
2 tasks
suda-morris
approved these changes
Nov 15, 2024
|
merged and released 2.0.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEDC driver was extended in espressif/esp-idf@4a90deb with new config structure members. We must zero init the config struct to get default behavior.
Related
Testing
Run esp32-camera example on S2 board.
Checklist
Before submitting a Pull Request, please ensure the following: