-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hard reset to rfc2217 server (ESPTOOL-760) #929
Conversation
👋 Welcome 20162026, thank you for your first contribution to 📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics. Pull request review and merge process you can expectWe do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
|
Hi @20162026, I have synced the PR to our internal queue and will be testing the change soon. After a first look, the code LGTM! I would like to ask you to do some stylistic changes:
Thank you! |
6f85bd6
to
c6ef1e2
Compare
hi @radimkarnis, |
@20162026 thank you! |
c6ef1e2
to
d66de5c
Compare
@radimkarnis fixed. |
@radimkarnis I've noticed that the link to the project contribution guide is invalid in #929 (comment). |
Hi @20162026. Thank you for your contribution. We will be happy to receive any feedback regarding the contribution process. Maybe we can something improve in our guides? |
@20162026 thank you again! Now merged to master. This will propagate to ESP-IDF for use with other tools with the next esptool release. |
add hard reset functionality to rfc2217 server and modify bootloader reset to trigger on DTR_ON instead of RTS_ON. This modification allows to use a rfc2217 server with idf_monitor and other compatible serial monitoring tools.
I'm not a python or rfc2217 expert and was assuming the default reset sequence, so there could be some issues with custom sequences.
This change fixes the following bug(s):
#892
I have tested this change with the following hardware & software combinations:
I have tested esp_rfc2217_server.py on windows10 and Ubuntu 22.04.2 LTS using custom esp32-wroom-32 board with the usual automatic bootloader circuit.
I have run the esptool.py automated integration tests with this change and the above hardware:
NO TESTING