fix: close file gracefully in espsecure (ESPTOOL-804) #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The espsecure.py script displays a ResourceWarning error regarding unclosed files when
PYTHONWARNINGS="all"
turns on. This issue arises because espsecure.py utilizes argparse.FileType, which opens a file handler but Python does not automatically handle the close() operation.This fix is to handle the close() explicitly to have a gracefully exit and avoid memory leaks.