-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(flashing): Update error when connecting to serial port fails on linux (ESPTOOL-874) #984
Conversation
👋 Hello OrhanYigitDurmaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @OrhanYigitDurmaz, Adding more instructions is always welcome. In this case, we believe that instead of adding instructions for different Linux distros directly to the error message, we should go the opposite way - simplify the message and extend the Troubleshooting guide section in the docs instead. Would you be interested to move the information there? Also, please take a look at the github-actions bot recommendations above this comment. The commit message is missing the type and scope. Thanks! |
You're right. Then giving the link to here is better. Maybe you could also add this to the troubleshooting section? |
Also looks like lint_esptool has some broken dependencies and thus, fails. |
Do you want to finish the PR, or should we take over, then?
That's unrelated to this PR, don't worry about the failure. |
This pull request makes more description on linux based systems when esptool cant connect to the serial port defined by the user.
This change fixes the following bug(s):
I have tested this change with the following hardware & software combinations:
Tested on Arch, Ubuntu 22.04 and 20.04 and Windows 10
I have run the esptool.py automated integration tests with this change and the above hardware:
NO TESTING