Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Edit to Minimize Future Upload Errors (ESPTOOL-879) #989

Closed
wants to merge 1 commit into from

Conversation

JohnGF
Copy link

@JohnGF JohnGF commented Jul 4, 2024

Based on community forums and personal experience, I propose an edit to the documentation/code to help minimize future errors during code uploads. This change aims to clarify that, in at least some implementations of the chip, it is necessary to hold the boot button until the connection is established when attempting to upload code or firmware.

I apologize if this change is deemed unnecessary, but I believe it will help prevent potential issues for users.

Thank you for considering this request.
Best regards,
João GF

This change fixes the following bug(s):

I have tested this change with the following hardware & software combinations:

I have run the esptool.py automated integration tests with this change and the above hardware:

Based on community forums and personal experience I purpose a edit like this to try to minimize errors
Copy link

github-actions bot commented Jul 4, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Just an attempt to clarify doc":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JohnGF, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 445e0f0

@github-actions github-actions bot changed the title Proposed Edit to Minimize Future Upload Errors Proposed Edit to Minimize Future Upload Errors (ESPTOOL-879) Jul 4, 2024
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. I've left one suggestion.

Also please see the contribution guide and install the pre-commit hooks which will guide you to make commits in the required format.

@@ -164,6 +164,7 @@ Manual Bootloader
Depending on the kind of hardware you have, it may also be possible to manually put your {IDF_TARGET_NAME} board into Firmware Download mode (reset).

- For development boards produced by Espressif, this information can be found in the respective getting started guides or user guides. For example, to manually reset a development board, hold down the **Boot** button (``{IDF_TARGET_STRAP_BOOT_GPIO}``) and press the **EN** button (``EN`` (``CHIP_PU``)).
- Note: Only release **Boot** button when connection is established.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not entirely true. It is not needed to enter Download mode, just to stay there if for some reason esptool's reset sequence on connection doesn't work.

I think we could add a note as the last item stating that this in practice means to hold the boot button or pull the boot pin down while starting esptool (with the default reset sequence) and keeping this until esptool establishes connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants