-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Edit to Minimize Future Upload Errors (ESPTOOL-879) #989
Conversation
Based on community forums and personal experience I purpose a edit like this to try to minimize errors
👋 Hello JohnGF, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request. I've left one suggestion.
Also please see the contribution guide and install the pre-commit hooks which will guide you to make commits in the required format.
@@ -164,6 +164,7 @@ Manual Bootloader | |||
Depending on the kind of hardware you have, it may also be possible to manually put your {IDF_TARGET_NAME} board into Firmware Download mode (reset). | |||
|
|||
- For development boards produced by Espressif, this information can be found in the respective getting started guides or user guides. For example, to manually reset a development board, hold down the **Boot** button (``{IDF_TARGET_STRAP_BOOT_GPIO}``) and press the **EN** button (``EN`` (``CHIP_PU``)). | |||
- Note: Only release **Boot** button when connection is established. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not entirely true. It is not needed to enter Download mode, just to stay there if for some reason esptool's reset sequence on connection doesn't work.
I think we could add a note as the last item stating that this in practice means to hold the boot button or pull the boot pin down while starting esptool (with the default reset sequence) and keeping this until esptool establishes connection.
Based on community forums and personal experience, I propose an edit to the documentation/code to help minimize future errors during code uploads. This change aims to clarify that, in at least some implementations of the chip, it is necessary to hold the boot button until the connection is established when attempting to upload code or firmware.
I apologize if this change is deemed unnecessary, but I believe it will help prevent potential issues for users.
Thank you for considering this request.
Best regards,
João GF
This change fixes the following bug(s):
I have tested this change with the following hardware & software combinations:
I have run the esptool.py automated integration tests with this change and the above hardware: