-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Updates to 2 apps, including 1 new one (HeatSuite) - merged commits #3827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Internal testing on the HeatSuite widget and fixed the miss-handling of rr intervals and heatflux from the BTHRM and coretemp sensor, respectively. |
Please say when you want me to look at merging :) |
Go for it @thyttan :) |
Ok! Will try to get to it tonight 👍 |
Cool project! Some notes from testing:
|
Great - this seems to be working fine now! I'll just give @hughbarney a day or two to look at Also, if you could split 2e85c3570cd1c21fdb18af95ab86b701ea69a766 so it becomes two commits, one for Thanks again! ☀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed Icon centering - wasn't 48x48 px in first go. :)
Splitting the commit into two is above my git knowledge... but if theres a tutorial on it I would be happy to learn.
apps/heatsuite/app-icon.js
Outdated
@@ -0,0 +1 @@ | |||
require("heatshrink").decompress(atob("lsw4kC///A4IDB0UQqOMnnn8n6uut6ecrPO997x1zllj11z333885kQABGx8CCYUikANH8oXICpd2s2QCxIVIy1ms1QCxAVIg1pg9nIhIJIFQOWuByIAwtYwsAhJCBsoEBw/gR5VziM3IYNmtMAhURiZdIAAPjj/xnxaCFYMR4cfCpMJicA+KZBTgVB4FRiAWJyM1qcUFgfsj/nEAIAFhHKJgPxiMRj+V5+gMAIAB6EAzfHCoUPMYOQgvxj9DiMxAIMTx8T2EAuMRjYrCidPMYXugHriP0mM0gEOBQMDjmhjIFB4NAyMwJQcDjMEjgHDgp8CwCmBj+bibYE+PJ+OgA4ehjGTFgVTMgX5x/0gEHAwM1JAP/u5gBPYIcCrk/ugJCHwMH+fJPgQABm9Pnb7FgvBjGBiqoEid9iNAcBI0B+JdE0Ow8LgKqMaoMfegIABucTxhVDAAdWswQB0JRC4kx+7nCiI0Bu1mLIXmswWCvnHrgRCiM08nMBYIVBsxVCs3pAoQHCmNO+P1BAcGsvmsoFBu2Qq1gcBcOEgI9CFgIzBBYNVgGfiM8mMb8EJqAsBIQNuGQQFB8EF+Mf4MTZ4PxifTiPOQAVpY4eZAYPxmbhBr2EuAwBicR4EA9OVUA2Rn3jjAHDhkfhMTZJMHBYMxZIcAoPAqMeCY2YyHqHQPxmB5BxICBiPziM4h13OgIAB2IKCAIM5gHvLgMAhERj56BPALkBgFxAwMfyEHv0AhYwBi58BvMAwcR/8RFoMMjRjGLYJXBA4dRn0PPgWx4GB+ANDqcYQgPgcAcRz3xIYJjBmMUAgOqz2jV4UTwF7oo9BCAM+TIUxjpnCBQMf6cTp4FBPAXsiP5HgdeGwMx5kR+8As2QhExnvxJ4MOTgbgE+EPQQMGtMAhUcK4LgJgsRzLgCFgMAwP5oLSBABBjBiI6Bq1m8BLBiJ8BABPrme+CoVmGoPD/AQFkAZHg1mqxaBAA8iBJFmqGWsALHgQWIFgOWFhAVBCxBZDCpIWIq9p8AVKkRyINpAABA=")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
centred icon
Here's a guide on interactive rebasing, where the "edit" command will be useful: https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line I'd maybe suggest making a test or backup branch so you don't risk losing anything, in terminal: git switch master;
git switch --create myBackup;
git whatchanged; <-- verify all your commits are in the backup branch
git switch master;
git rebase --interactive; <-- now follow the guide linked above |
It would be nice, but if it feels too cumbersome I wont force you. |
As requested by @thyttan, I merged the commits for each app.
Specific changes below:
coretemp: Revised the application to be more like the BTHRM app. Added the ability to pair an ANT+ heart rate strap directly to the CORE Sensor so it can use the exertional algorithm when HR > 120 BPM.
gpssetup: Added adaptive mode where it can scan for GPS signals more frequently if a signal was found. Otherwise, reverts back to normal scan interval.
heatsuite: New app.