Skip to content

Updates to 2 apps, including 1 new one (HeatSuite) - merged commits #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

nravanelli
Copy link
Contributor

As requested by @thyttan, I merged the commits for each app.

Specific changes below:

coretemp: Revised the application to be more like the BTHRM app. Added the ability to pair an ANT+ heart rate strap directly to the CORE Sensor so it can use the exertional algorithm when HR > 120 BPM.

gpssetup: Added adaptive mode where it can scan for GPS signals more frequently if a signal was found. Otherwise, reverts back to normal scan interval.

heatsuite: New app.

@nravanelli
Copy link
Contributor Author

Internal testing on the HeatSuite widget and fixed the miss-handling of rr intervals and heatflux from the BTHRM and coretemp sensor, respectively.

@thyttan
Copy link
Collaborator

thyttan commented May 5, 2025

Please say when you want me to look at merging :)

@nravanelli
Copy link
Contributor Author

Go for it @thyttan :)

@thyttan
Copy link
Collaborator

thyttan commented May 5, 2025

Ok! Will try to get to it tonight 👍

@thyttan
Copy link
Collaborator

thyttan commented May 5, 2025

Cool project!

Some notes from testing:

  • The widget seems to invert the background colour.
    • But it looks intentional - so like it should be? Looks kindof nice!
      • In that case maybe you'd want to invert some of the dark dots in the icon when the background is dark? just a thought.
  • Trying to start Core Temp I get:
 ____                 _
|  __|___ ___ ___ _ _|_|___ ___
|  __|_ -| . |  _| | | |   | . |
|____|___|  _|_| |___|_|_|_|___|
         |_| espruino.com
 2v25.378 (c) 2025 G.Williams
Uncaught undefined
Uncaught Error: Function "setCORESensorPower" not found!
 at line 11 col 784 in coretemp.app.js
....getHeight()/2+16);}Bangle.setCORESensorPower(1,"COREAPP");B...
                              ^
> 
  • Most of the HeatSuite icon is invisible on dark theme:
    image
    • I don't think you must update it, but maybe it makes sense to invert the dark dots? But maybe it's unnecessary hassle.
  • Widgets decided to draw over the HeatSuite UI:
    image
    • but it may be a quirk of my watch setup - not sure!
    • This happened when clicking either of the two red buttons (top right).
  • It says Searching... in the bottom - is it looking for a GPS fix?
  • I suggest you add a screenshot of the app ui and describe what the different buttons do in the README.
  • Clicking the scale button (bottom left) does nothing for me? (I don't have a scale connected)
  • HeatSuite seems add a swipe gesture on the clock face for starting the app?
    • Is that intended? If so, please document it in the README.
    • I'd suggest a setting so it can be toggled off.
  • HeatSuite seemed to disable much of my bootcode apps.

@thyttan
Copy link
Collaborator

thyttan commented May 7, 2025

Great - this seems to be working fine now!

I'll just give @hughbarney a day or two to look at gpssetup and @ihewitt at coretemp as creators of respective app, if they should spot something.

Also, if you could split 2e85c3570cd1c21fdb18af95ab86b701ea69a766 so it becomes two commits, one for coretemp and one for heatsuite?

Thanks again! ☀️

@thyttan
Copy link
Collaborator

thyttan commented May 7, 2025

I just noticed, the icon is not centered on the watch:
image

Compare with PA Remote:
image

I will not hold the PR back for this, but polish is always nice (which Heatsuite has plenty!).

Copy link
Contributor Author

@nravanelli nravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Icon centering - wasn't 48x48 px in first go. :)

Splitting the commit into two is above my git knowledge... but if theres a tutorial on it I would be happy to learn.

@@ -0,0 +1 @@
require("heatshrink").decompress(atob("lsw4kC///A4IDB0UQqOMnnn8n6uut6ecrPO997x1zllj11z333885kQABGx8CCYUikANH8oXICpd2s2QCxIVIy1ms1QCxAVIg1pg9nIhIJIFQOWuByIAwtYwsAhJCBsoEBw/gR5VziM3IYNmtMAhURiZdIAAPjj/xnxaCFYMR4cfCpMJicA+KZBTgVB4FRiAWJyM1qcUFgfsj/nEAIAFhHKJgPxiMRj+V5+gMAIAB6EAzfHCoUPMYOQgvxj9DiMxAIMTx8T2EAuMRjYrCidPMYXugHriP0mM0gEOBQMDjmhjIFB4NAyMwJQcDjMEjgHDgp8CwCmBj+bibYE+PJ+OgA4ehjGTFgVTMgX5x/0gEHAwM1JAP/u5gBPYIcCrk/ugJCHwMH+fJPgQABm9Pnb7FgvBjGBiqoEid9iNAcBI0B+JdE0Ow8LgKqMaoMfegIABucTxhVDAAdWswQB0JRC4kx+7nCiI0Bu1mLIXmswWCvnHrgRCiM08nMBYIVBsxVCs3pAoQHCmNO+P1BAcGsvmsoFBu2Qq1gcBcOEgI9CFgIzBBYNVgGfiM8mMb8EJqAsBIQNuGQQFB8EF+Mf4MTZ4PxifTiPOQAVpY4eZAYPxmbhBr2EuAwBicR4EA9OVUA2Rn3jjAHDhkfhMTZJMHBYMxZIcAoPAqMeCY2YyHqHQPxmB5BxICBiPziM4h13OgIAB2IKCAIM5gHvLgMAhERj56BPALkBgFxAwMfyEHv0AhYwBi58BvMAwcR/8RFoMMjRjGLYJXBA4dRn0PPgWx4GB+ANDqcYQgPgcAcRz3xIYJjBmMUAgOqz2jV4UTwF7oo9BCAM+TIUxjpnCBQMf6cTp4FBPAXsiP5HgdeGwMx5kR+8As2QhExnvxJ4MOTgbgE+EPQQMGtMAhUcK4LgJgsRzLgCFgMAwP5oLSBABBjBiI6Bq1m8BLBiJ8BABPrme+CoVmGoPD/AQFkAZHg1mqxaBAA8iBJFmqGWsALHgQWIFgOWFhAVBCxBZDCpIWIq9p8AVKkRyINpAABA="))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centred icon

@thyttan
Copy link
Collaborator

thyttan commented May 7, 2025

Here's a guide on interactive rebasing, where the "edit" command will be useful: https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line

I'd maybe suggest making a test or backup branch so you don't risk losing anything, in terminal:

git switch master;
git switch --create myBackup;
git whatchanged;   <-- verify all your commits are in the backup branch
git switch master;
git rebase --interactive;    <-- now follow the guide linked above

@thyttan
Copy link
Collaborator

thyttan commented May 7, 2025

It would be nice, but if it feels too cumbersome I wont force you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants