Skip to content

widget_utils: only setLCDOverlay if present #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

widget_utils: only setLCDOverlay if present #3832

merged 1 commit into from
Apr 28, 2025

Conversation

bobrippling
Copy link
Collaborator

Fixes #3830

@bobrippling bobrippling mentioned this pull request Apr 26, 2025
Closed
@thyttan
Copy link
Collaborator

thyttan commented Apr 26, 2025

I'll leave this to @gfwilliams 🙏

@gfwilliams
Copy link
Member

Thanks! Yes, this looks good - I guess since we made show work for both hide/swipeOn it started calling stuff that we'd never worry about on Bangle.js 1 - @thyttan I guess this is one of those reasons splitting it up a bit like you'd suggested before might be good

@gfwilliams gfwilliams merged commit abb6f48 into espruino:master Apr 28, 2025
1 check passed
@thyttan
Copy link
Collaborator

thyttan commented Apr 28, 2025

I guess this is one of those reasons splitting it up a bit like you'd suggested before might be good

#3796 for reference

@bobrippling bobrippling deleted the fix/widget-utils-lcd branch April 28, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bobrippling @thyttan @gfwilliams