Skip to content

Commit

Permalink
Fix error decoding on ts-binding
Browse files Browse the repository at this point in the history
  • Loading branch information
DmitryAstafyev committed Oct 23, 2024
1 parent 68e6052 commit 4016c2c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export class EventProvider extends Computation<
SearchValuesUpdated: new Subject<IValuesMinMaxMap | null>(),
SearchMapUpdated: new Subject<string>(),
IndexedMapUpdated: new Subject<IEventIndexedMapUpdated>(),
Progress: new Subject<IProgressEvent>(),
Progress: new Subject<IProgressEvent>(), // This even isn't used. No listeners on ts side and never fires on rs side
AttachmentsUpdated: new Subject<IAttachmentsUpdatedUpdated>(),
SessionError: new Subject<IError>(),
OperationError: new Subject<IErrorEvent>(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export class NativeError extends Error {
try {
if (smth instanceof Error) {
return new NativeError(smth, Type.Other, Source.Other);
} else if (smth instanceof Array) {
} else if (smth instanceof Array || smth instanceof Buffer) {
const deserialized: ty.ComputationError = proto.ComputationError.decode(
Uint8Array.from(smth),
);
Expand Down

0 comments on commit 4016c2c

Please sign in to comment.