Inserting type and main into package.json for flow-web
#1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard coding the name the file should use to ensure it matches expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To import
flow-webinto vitest we need to set thetypeandmainin thepackage.jsonfile. Right nowwasm-packis not including these but there is a PR has merged that should fix this.Also hard cording the name for the output to
flow_webto ensure these new props are set correctly.Workflow steps:
N/A
Documentation links affected:
N/A
Notes for reviewers:
As called out in the comment in the YAML - this is kind of hacky but is a known hack that folks have been doing to work around the issue. We should probably keep an eye on
wasm-packto see when it releases a new version (hopefully with the fix for this)This change is