dekaf: Swap to lz4_flex from lz4
#1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating the cause of LZ4 compression issues related to franz-go (see comments here #1651), I found `lz4_flex` which is a pure-Rust lz4 implementation which appears to be safer and faster than `lz4`/`lz4-sys` that `kafka-protocol` is using. Now that tychedelia/kafka-protocol-rs#81 allows us to use our own compression, and `lz4`'s configuration of block checksums is broken (fix here 10XGenomics/lz4-rs#52), I thought it would be a good time to swap to `lz4_flex`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the cause of LZ4 compression issues related to franz-go (#1651 (comment)), I found
lz4_flexwhich is a pure-Rust lz4 implementation which appears to be safer and faster thanlz4/lz4-systhatkafka-protocolis using.Now that tychedelia/kafka-protocol-rs#81 allows us to use our own compression, and
lz4's configuration of block checksums is broken (fix here 10XGenomics/lz4-rs#52), I thought it would be a good time to swap tolz4_flex.I've confirmed that this change also fixes the issue with block checksums, mainly because
lz4_flex's block checksums are actually off by default (unfortunately, turning them on reproduces the issue).This change is