Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the translation for evolved backfill notifications #1422

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 16, 2025

Issues

#1421

Changes

1421

  • Need to pass the count to the inner translate and not the outer translate

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

image

@travjenkins travjenkins added the change:unplanned Unplanned change, useful for things like doc updates label Jan 16, 2025
@travjenkins travjenkins marked this pull request as ready for review January 16, 2025 19:10
@travjenkins travjenkins requested a review from a team as a code owner January 16, 2025 19:10
@travjenkins travjenkins changed the title Need to pass the count into the itemType translation and not the Fix the translation for evolved backfill notifications Jan 16, 2025
@travjenkins travjenkins merged commit e679c93 into main Jan 16, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/bug/hide-backfill-message branch January 16, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants