Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling on entity create/edit edge cases #1455

Merged
merged 13 commits into from
Feb 12, 2025
Merged

Better handling on entity create/edit edge cases #1455

merged 13 commits into from
Feb 12, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Feb 6, 2025 •
edited
Loading

Issues

#1454
#1456

Changes

1454

  • I think we should always assume the config must provide some fields until we are proven otherwise. I am not totally sure why we went with this default.

1456

  • No longer allowing the connector to be changed on the create page
  • Now back button will take the user to the connector selection screen

Misc

  • Allow the connector and data plane renderers to show the label and helper text in a disabled manner properly.
  • Do not actually render the help docs iframe unless we are showing them
  • Add LR eventing for help docs

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Before the change
Image

After the change
Image

Disabled fields showing properly

image

Connector select is now disabled

image

travjenkins
travjenkins commented Feb 6, 2025
View reviewed changes
src/utils/misc-utils.ts
return false;
}

return Boolean(!schema.properties || isEmpty(schema.properties));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this introduced the ability for a race condition

https://github.com/estuary/ui/pull/1230/files#r1729428622
image

@travjenkins travjenkins changed the title Do not assume a config can be empty Better handling on entity create/edit edge cases Feb 10, 2025
@travjenkins travjenkins marked this pull request as ready for review February 10, 2025 20:58
@travjenkins travjenkins requested a review from a team as a code owner February 10, 2025 20:58
@travjenkins travjenkins merged commit f49e392 into main Feb 12, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/bug/better-handling-of-empty-configs branch February 12, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker