Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es_extended/client/functions.lua): bug fix with the menu close & closeall function #1472

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

zImSkillz
Copy link
Contributor

As the title says, this fixes a bug that occurs when using the menu- close or close all function with the cancel argument set.

The error was that the Cancel function was called without any further arguments, as it normally is.

@Mycroft-Studios Mycroft-Studios changed the base branch from main to dev November 16, 2024 20:15
Copy link
Contributor

@Kenshiin13 Kenshiin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the PR Guidelines.

@zImSkillz zImSkillz changed the title Bug Fix with the Menu Close & Closeall function fix(es_extended/client/functions.lua): bug fix with the menu close & closeall function Nov 17, 2024
@zImSkillz zImSkillz requested a review from Kenshiin13 November 17, 2024 15:56
Kenshiin13
Kenshiin13 previously approved these changes Nov 17, 2024
@Kenshiin13 Kenshiin13 dismissed their stale review November 17, 2024 16:51

Still needs testing

[core]/es_extended/client/functions.lua Show resolved Hide resolved
[core]/es_extended/client/functions.lua Show resolved Hide resolved
@Kenshiin13 Kenshiin13 dismissed their stale review November 17, 2024 22:47

I am dumb.

Copy link
Contributor

@Kenshiin13 Kenshiin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Kenshiin13 Kenshiin13 merged commit 7cf3673 into esx-framework:dev Nov 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Published
Development

Successfully merging this pull request may close these issues.

2 participants