Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esx_multicharacter/server/modules/database): improve database name extraction #1515

Closed
wants to merge 1 commit into from

Conversation

RrybaN
Copy link
Contributor

@RrybaN RrybaN commented Nov 29, 2024

This fix resolves an issue where parsing the mysql_connection_string in the format user=root;password=12345;host=localhost;port=3306;database=fivem would throw an error attempt to perform arithmetic on a nil value. Additionally, i added a error log if database name is not found in the mysql_connection_string

@Kenshiin13 Kenshiin13 changed the base branch from main to dev November 29, 2024 16:45
@RrybaN RrybaN closed this Nov 29, 2024
@RrybaN RrybaN reopened this Nov 29, 2024
@RrybaN
Copy link
Contributor Author

RrybaN commented Nov 29, 2024

@Mycroft-Studios any info why this was closed?

@Mycroft-Studios
Copy link
Member

sinced since #1516 Is the correct fix.
This part of the code, was wrote by ox, so i get the feeling their extract method is alot more accuate :)

@RrybaN
Copy link
Contributor Author

RrybaN commented Nov 29, 2024

Hmm, well okay, got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recycle Bin
Development

Successfully merging this pull request may close these issues.

2 participants