Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix health calculation for female players & status thread #98

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix(client): fix health calculation for female players & status thread #98

merged 2 commits into from
Dec 23, 2024

Conversation

Kenshiin13
Copy link
Contributor

Summary

  • Fixed an issue where player health percentage would show 133% for female players.
  • Fixed an issue where the status thread would be started before the player has fully loaded, causing it to break out of the loop and never update again.

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@Kenshiin13
fix(client/player/status): fix health calculation for female players
a332069 
Players have a max health of 200, regardless of gender. Eventhough GET_ENTITY_MAX_HEALTH will retun 175 for female players, NETWORK_RESURRECT_LOCAL_PLAYER will respawn the player with 200 health, causing the health percentage to go over 100%.
@Kenshiin13
fix(client/main): wait for player to load before starting status thread
7c882b9
@Kenshiin13 Kenshiin13 self-assigned this Dec 23, 2024
N0tNvll
N0tNvll approved these changes Dec 23, 2024
View reviewed changes
Copy link

@N0tNvll N0tNvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix for get actual female health player
  • Prevention to get player data in case that the ped didnt load

@Kenshiin13 Kenshiin13 merged commit ac192c7 into dev Dec 23, 2024
1 check passed
@Kenshiin13 Kenshiin13 deleted the fix-hud branch December 23, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N0tNvll N0tNvll N0tNvll approved these changes

@Mycroft-Studios Mycroft-Studios Awaiting requested review from Mycroft-Studios

Assignees

@Kenshiin13 Kenshiin13

Labels
None yet
Projects
ESX Roadmap
Status: Ready for Next Update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kenshiin13 @N0tNvll