-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRPC Proxy TLS version Changelog updates #18897
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #18897 +/- ##
==========================================
+ Coverage 68.71% 68.75% +0.04%
==========================================
Files 420 420
Lines 35558 35558
==========================================
+ Hits 24433 24448 +15
+ Misses 9695 9683 -12
+ Partials 1430 1427 -3 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Thomas Jungblut <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -85,6 +85,7 @@ See [code changes](https://github.com/etcd-io/etcd/compare/v3.5.0...v3.6.0). | |||
|
|||
- Add [`etcd grpc-proxy start --endpoints-auto-sync-interval`](https://github.com/etcd-io/etcd/pull/14354) flag to enable and configure interval of auto sync of endpoints with server. | |||
- Add [`etcd grpc-proxy start --listen-cipher-suites`](https://github.com/etcd-io/etcd/pull/14308) flag to support adding configurable cipher list. | |||
- Add [`add tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18816) support setting TLS min and max version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Remove duplicated verb
- Add [`add tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18816) support setting TLS min and max version. | |
- Add [`tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18816) to support setting TLS min and max version. |
@@ -8,6 +8,10 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
## Dependencies | |||
- Bump [golang-jwt/jwt to 4.5.1 to address GO-2024-3250](https://github.com/etcd-io/etcd/pull/18899). | |||
|
|||
### etcd grpc-proxy | |||
- Add [`add tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18829) support setting TLS min and max version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Remove duplicated verb
- Add [`add tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18829) support setting TLS min and max version. | |
- Add [`tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18829) to support setting TLS min and max version. |
waiting for #18829 to be merged
/hold