-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] Bump golang-jwt/jwt to 4.5.1 to address GO-2024-3250 #18899
Conversation
275e3be
to
79320cc
Compare
fixes etcd-io#18898 Signed-off-by: Thomas Jungblut <[email protected]>
79320cc
to
e61b495
Compare
/retitle [3.5] Bump golang-jwt/jwt to 4.5.1 to address GO-2024-3250 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @tjungblu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We had a failure in the trivy scan. Again, GHCR replied with a 429 (https://github.com/etcd-io/etcd/actions/runs/11856210750/job/33042258548?pr=18899). Thomas' branch is up to date and has the ECR workaround. It also looks like the error was in another image (not trivy-db). We should keep an eye on this workflow.
|
fixes #18898
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.