-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiply return time by 100 in tests to detect off by one differences #18908
Conversation
cc @fuweid |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #18908 +/- ##
==========================================
+ Coverage 68.71% 68.74% +0.03%
==========================================
Files 420 420
Lines 35558 35558
==========================================
+ Hits 24433 24445 +12
+ Misses 9695 9682 -13
- Partials 1430 1431 +1 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Marek Siarkowicz <[email protected]>
df81594
to
3d33c09
Compare
/retest |
ping @jmhbnz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @serathius
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fuweid, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327 @siyuanfoundation @jmhbnz