Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply return time by 100 in tests to detect off by one differences #18908

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

serathius
Copy link
Member

@serathius
Copy link
Member Author

cc @fuweid

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (ee789c9) to head (8f45a79).

Current head 8f45a79 differs from pull request most recent head 3d33c09

Please upload reports for the commit 3d33c09 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18908      +/-   ##
==========================================
+ Coverage   68.71%   68.74%   +0.03%     
==========================================
  Files         420      420              
  Lines       35558    35558              
==========================================
+ Hits        24433    24445      +12     
+ Misses       9695     9682      -13     
- Partials     1430     1431       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee789c9...3d33c09. Read the comment docs.

@serathius
Copy link
Member Author

/retest

@serathius
Copy link
Member Author

ping @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit ce13079 into etcd-io:main Nov 20, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants