-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimum setup for the Ukrainian translation #942
base: main
Are you sure you want to change the base?
Conversation
Hi @jverce. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0808c16
to
fb47d2c
Compare
@jverce Thank you a lot to make things going. Have you thought about extracting language specific settings into separate files, one per language. I hope this will help to make it easier to manage multiple languages simultaneously. UPD RE https://gohugo.io/getting-started/configuration/#configuration-directory |
Yes, localization is a complicated thing. How to present languages in the language selector is also a question that can be a bit confusing 🙃. Here's a good resource that explains in detail why country flags are not identical to the languages people use. I hope you find it useful. https://www.flagsarenotlanguages.com/blog/ |
layouts/index.redirects
Outdated
{{- $lang := .Lang -}} | ||
{{- if ne $lang "en" -}} | ||
|
||
/{{ $lang }}/** /{{ $lang }}/404.html 404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to follow netlify's recommendations locally, but without success
https://docs.netlify.com/routing/redirects/redirect-options/#custom-404-page-handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And netlify build action failed here also
6:07:05 PM: ========================================================================
6:07:21 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)
6:07:21 PM: uk/404.html
6:07:21 PM: target does not exist --- uk/404.html --> /uk/docs/latest/
6:07:21 PM: target does not exist --- uk/404.html --> /uk/docs/latest/install/
6:07:21 PM: target does not exist --- uk/404.html --> /uk/docs/v3.5/
6:07:21 PM: uk/index.html
6:07:21 PM: target does not exist --- uk/index.html --> /uk/docs/latest/
6:07:21 PM: target does not exist --- uk/index.html --> /uk/docs/latest/install/
6:07:21 PM: target does not exist --- uk/index.html --> /uk/docs/v3.5/
6:07:21 PM: ========================================================================
6:07:21 PM: ✘✘✘ failed in 15.853956324s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the error is also due to the absence of the files content/uk/_index.html
, content/uk/docs/_index.md
, and content/uk/docs/v3.5/_index.md
. What if you create empty stub files instead of them now?
@jverce It looks like I managed to split config.yaml into separate parts. This should make it much easier to add new languages and implement CAT-tools in the future. (See It looks like this ➜ tree config
config
└── _default
├── config.yaml
├── language.en.yaml
├── language.uk.yaml
└── navigation
├── menus.en.yaml
└── menus.uk.yaml It would be good if you could integrate these changes into this PR. UPD main...Andygol:etcd-io-website:config-dir |
@jverce could you please review and merge the PR jverce#1 where the most recent changes are located, comparable to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Andygol, jverce The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add `uk` entry to the languages config (disabled for now) * Add the Ukrainian translation of the homepage * Add `404 Not Found` page and redirect all `/uk/*` URLs to it * Make the build/serve commands output i18n warnings * Add configuration files for English and Ukrainian languages, including site parameters and navigation menus * Move global repository configuration URLs to config files * Add `latest_stable_version` parameter to the `config.yaml` file * Add NPM command to serve with debug logs Signed-off-by: Jay Vercellone <[email protected]> Co-authored-by: Andrii Holovin <[email protected]>
b9d26db
to
2b74076
Compare
Changelog
uk
entry to the config file404 Not Found
page and redirect all/uk/**
URLs to itContext