Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input, Icon and Wrap #10

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Input, Icon and Wrap #10

merged 5 commits into from
Feb 9, 2024

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Feb 9, 2024

I've been a bit all over the place here, trying to get things looking right:

  • Fixed typing with a CustomElement<T> type
  • Added a custom wrap which limits the content width, it works well for these start screens and tips but might need to escape it later, in which case I'll probably use diamond-wrap instead
  • Handled lazy loading icons via vite-plugin-svgr
  • Integrated diamond components to layout the start page
  • Adjusted the font weight to match the design, don't think I'll expose this at the moment
  • Added a --color-primary which will work like a base brand/accent color which exposes an easy/safe way to globally apply brand colours through one variable

@DanWebb DanWebb self-assigned this Feb 9, 2024
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DanWebb DanWebb merged commit c0b8b19 into main Feb 9, 2024
4 checks passed
@DanWebb DanWebb deleted the feature/wrap-157-input-component branch February 9, 2024 17:59
@DanWebb
Copy link
Member Author

DanWebb commented Mar 8, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mergify mergify bot requested a review from Carl-J-M March 8, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants