Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container SVG undefined #204

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix container SVG undefined #204

merged 1 commit into from
Jul 12, 2024

Conversation

DanWebb
Copy link
Member

@DanWebb DanWebb commented Jul 12, 2024

Although reduced, we're still getting the "Unknown variable dynamic import: ./svg/undefined.svg" errors

Based on the tag, they all seem to be from the container SVG now, so I've applied the same fix to this component as was given to the icon component.

Screenshot 2024-07-12 at 13 53 42

@DanWebb DanWebb self-assigned this Jul 12, 2024
Copy link

sonarcloud bot commented Jul 12, 2024

@mergify mergify bot requested review from ella-etch and gavmck July 12, 2024 12:55
Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY checkov yes no 19.64s
⚠️ REPOSITORY gitleaks yes 6 2.9s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.86s
✅ REPOSITORY trivy-sbom yes no 1.84s
✅ REPOSITORY trufflehog yes no 31.78s
✅ TSX eslint 1 0 6.16s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@mergify mergify bot merged commit 59440cf into main Jul 12, 2024
7 checks passed
@mergify mergify bot deleted the fix/undefined-svg branch July 12, 2024 13:01
@DanWebb
Copy link
Member Author

DanWebb commented Jul 12, 2024

🎉 This PR is included in version 1.50.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants