Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom network magic link #24

Draft
wants to merge 6 commits into
base: eternalsafe
Choose a base branch
from

Conversation

oed
Copy link

@oed oed commented Jan 23, 2025

What it solves

Resolves #3

How this PR fixes it

Adds a new useMagicNetwork hook that parses params for an rpc and custom network configuration. It also takes care of persisting both the rpc and the network.

How to test it

With this url:

localhost:3000?chain=test&rpc=https%3A%2F%2Fethereum-rpc.publicnode.com&chainId=9999&currency=Test&symbol=TEST&logo=https%3A%2F%2Favatars.githubusercontent.com%2Fu%2F144105645

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

vercel bot commented Jan 23, 2025

@oed is attempting to deploy a commit to the Eternal Safe Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Network Magic Link - Support custom EVM chains
1 participant