Move test resources to jfrog #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgphpc
reviewed
Nov 18, 2024
| @@ -9,12 +9,21 @@ | |||
| import reframe.utility.sanity as sn | |||
|
|
|||
|
|
|||
| class fetch_lampps_resources(rfm.RunOnlyRegressionTest): | |||
| executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz' | |||
There was a problem hiding this comment.
Suggested change
| executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz' | |
| jfrog = 'https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests' | |
| executable = f'wget {jfrog}/LAMMPS.tar.gz && tar -xvf LAMMPS.tar.gz' |
- maybe jfrog should be set in the config file(s) ?
There was a problem hiding this comment.
Not sure it's that useful because we have many tests pulling from jfrog in different directories. Do you think we will need to move them to a different directory eventually?
jgphpc
reviewed
Nov 18, 2024
| @@ -9,6 +9,14 @@ | |||
| import reframe.utility.sanity as sn | |||
|
|
|||
|
|
|||
| class fetch_namd_resources(rfm.RunOnlyRegressionTest): | |||
| executable = 'wget https://jfrog.svc.cscs.ch/artifactory/cscs-reframe-tests/NAMD.tar.gz && tar -xvf LAMMPS.tar.gz' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.