Siren fixes #1978
Merged
Siren fixes #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pietjepuk2
commented
Nov 4, 2024
pietjepuk2
commented
- Siren: Fix when CL_NODE is comma-separated list
- Siren: Fix connecting to BN/VC
added 2 commits
November 4, 2024 10:27
Siren would use the BEACON_URL as-is to connect to, which works for the Lighthouse VC but not for Siren. If it is a comma-separated list of BNs, we just pick the first one to connect to.
For some reason the BN and VC urls resolve to ipv6 addresses in the Siren container, which is not supported by those endpoints. We therefore force Siren to prefer ipv4 using an env variable for NodeJS applications. Note that this does not seem to be related to IPV6=true/false in .env .
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 eth-docker Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.