Detect Docker root dir on ethd run
#1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickdowne
force-pushed
the
promtail-docker-root
branch
2 times, most recently
from
38a09b7 to
6d37ca2
Compare
yorickdowne
force-pushed
the
promtail-docker-root
branch
from
6d37ca2 to
537b1e3
Compare
yorickdowne
changed the title
ethd run
pietjepuk2
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged at the exact same time as 1989 to make sure users get both changes in one update run
Add
DOCKER_ROOT, set it andNODE_EXPORTER_IGNORE_MOUNT_REGEXon everyethdrun.DOCKER_ROOTis always updated,NODE_EXPORTER_IGNORE_MOUNT_REGEXonly when it follows our standard pattern, so we don't break users that set it manually