Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run comment only if coverage-combine completed #128

Closed

Conversation

yorickdowne
Copy link

Changes

Avoid failing comment action when we're not running the full test suite

Types of changes

What types of changes does your code introduce?

  • Build-related changes

Testing

Requires testing

  • Yes
  • No

@yorickdowne yorickdowne marked this pull request as draft September 1, 2024 02:59
@yorickdowne
Copy link
Author

This workflow runs from main. The only way to test it is to merge it, as far as I can tell.

@yorickdowne yorickdowne marked this pull request as ready for review September 1, 2024 03:00
@yorickdowne
Copy link
Author

No it won't work that way. We really can't check on individual job status in a previous run without triggering a fail (see https://stackoverflow.com/questions/71963637/reusing-github-actions-jobs-results-from-a-workflow-when-called-on-workflow-run), so we'll always have a fail when we don't run tests.

C'est la vie. We can remove the conditional test running once we no longer pay for runners, if we like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant