Add linting to GH action workflow

[valefar-on-discord]

Include lint to GH action runner and ignore mypy issues for now.

I spent some time investigating but I believe each error is a result of an advanced inheritance model from py-ssz (https://github.com/ethereum/py-ssz/blob/main/ssz/sedes/byte_vector.py).

I wasn't able to find a reliable way to resolve these issues but I would rather ignore a few items than not have linting at all.

[valefar-on-discord]

I've been playing around trying to resolve the untyped mypy errors.
One method to resolve the specific error, of lets say Call to untyped function "ForkData" in typed context
You can utilize an init and call the super init with the params:

class ForkData(Serializable):
    fields = [
        ('current_version', bytes4),
        ('genesis_validators_root', bytes32),
    ]
    def __init__(self, current_version: bytes4, genesis_validators_root: bytes32) -> None:
        super().__init__(current_version, genesis_validators_root)

The problem here is this will create more errors:

error: Variable "ssz.sedes.byte_vector.bytes4" is not valid as a type  [valid-type]
note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
error: Variable "ssz.sedes.byte_vector.bytes32" is not valid as a type  [valid-type]
error: Call to untyped function "__init__" in typed context  [no-untyped-call]

I'm pretty sure there is a way to resolve the valid-type issue but I don't know how you would resolve the additional untyped-call.

Because of my struggle with this hydra, I decided to ignore them for now unless there are ideas on how to resolve them.

[remyroy]

I've ran the ci jobs again and I don't see any error from running mypy. Here is an output I'm seeing from https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/8675308188/job/23881195586

Run python -m mypy --config-file mypy.ini -p staking_deposit
  python -m mypy --config-file mypy.ini -p staking_deposit
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.1[2](https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/8675308188/job/23881195586#step:6:2).2/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/[3](https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/8675308188/job/23881195586#step:6:3).12.2/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.2/x6[4](https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/8675308188/job/23881195586#step:6:4)
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.2/x[6](https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/8675308188/job/23881195586#step:6:6)4
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.2/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.2/x64/lib
Success: no issues found in 64 source files

I'm guessing you fixed everything related to mypy.

[valefar-on-discord]

@remyroy I didn't fix them, I just ignored them...
signed_deposit = DepositData( # type: ignore[no-untyped-call]
as an example.

[remyroy]

I see. Thanks for the precision.

[remyroy]

Having these type check ignore is not ideal but it's better to run mypy regularly and have it pass on everything else than not having it or running it with errors and ignoring those errors.

[remyroy]

mypy is not a linter. Having or adding a linter would be probably be great and it could be done in another PR.

I would rename this step to Run type checker

[valefar-on-discord]

:)
ack

[remyroy]

Everything is good.