-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming project from staking_deposit to ethstaker_deposit #60
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ tox_common: &tox_common | |
key: tox-deps4-{{ arch }}-{{ .Environment.CIRCLE_JOB }}-{{ checksum "requirements.txt" }}-{{ checksum "requirements_test.txt" }}-{{ checksum "setup.py" }}-{{ checksum "Makefile" }} | ||
|
||
orbs: | ||
win: circleci/[email protected] # The Windows orb give you everything you need to start using the Windows executor. | ||
win: circleci/[email protected] # The Windows orb give you everything you need to start using the Windows executor. | ||
|
||
jobs: | ||
# Job(s) with Linux OS | ||
|
@@ -113,7 +113,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
mkdir ${BUILD_FILE_NAME}; | ||
pyenv global 3.12.1; | ||
pyinstaller --distpath ./${BUILD_FILE_NAME} ./build_configs/linux/build.spec; | ||
|
@@ -122,7 +122,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
export TEST_FOLDER_NAME=TMP_TEST_FOLDER | ||
mkdir ${TEST_FOLDER_NAME} | ||
cp -r ${BUILD_FILE_NAME} ${TEST_FOLDER_NAME} | ||
|
@@ -136,7 +136,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-amd64; | ||
tar -zcvf ${BUILD_FILE_NAME}.tar.gz ./${BUILD_FILE_NAME}; | ||
mkdir /tmp/artifacts; | ||
cp ${BUILD_FILE_NAME}.tar.gz /tmp/artifacts; | ||
|
@@ -161,7 +161,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
mkdir ${BUILD_FILE_NAME}; | ||
pyenv global 3.12.1; | ||
pyinstaller --distpath ./${BUILD_FILE_NAME} ./build_configs/linux/build.spec; | ||
|
@@ -170,7 +170,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
export TEST_FOLDER_NAME=TMP_TEST_FOLDER | ||
mkdir ${TEST_FOLDER_NAME} | ||
cp -r ${BUILD_FILE_NAME} ${TEST_FOLDER_NAME} | ||
|
@@ -183,7 +183,7 @@ jobs: | |
name: Compress the file | ||
command: | | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-linux-arm64; | ||
tar -zcvf ${BUILD_FILE_NAME}.tar.gz ./${BUILD_FILE_NAME}; | ||
mkdir /tmp/artifacts; | ||
cp ${BUILD_FILE_NAME}.tar.gz /tmp/artifacts; | ||
|
@@ -207,7 +207,7 @@ jobs: | |
command: | | ||
$PYTHONHASHSEED = 42 | ||
$CIRCLE_SHORT_SHA1 = $env:CIRCLE_SHA1.substring(0,7) | ||
$BUILD_FILE_NAME = "staking_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
$BUILD_FILE_NAME = "ethstaker_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
mkdir $BUILD_FILE_NAME | ||
$BUILD_FILE_NAME_PATH = ".\" + $BUILD_FILE_NAME | ||
pyinstaller --distpath $BUILD_FILE_NAME_PATH .\build_configs\windows\build.spec | ||
|
@@ -216,7 +216,7 @@ jobs: | |
command: | | ||
$PYTHONHASHSEED = 42 | ||
$CIRCLE_SHORT_SHA1 = $env:CIRCLE_SHA1.substring(0,7) | ||
$BUILD_FILE_NAME = "staking_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
$BUILD_FILE_NAME = "ethstaker_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
$TEST_FOLDER_NAME = "TMP_TEST_FOLDER" | ||
mkdir ${TEST_FOLDER_NAME} | ||
Copy-item ${BUILD_FILE_NAME} -destination ${TEST_FOLDER_NAME} -recurse | ||
|
@@ -230,7 +230,7 @@ jobs: | |
command: | | ||
$PYTHONHASHSEED = 42 | ||
$CIRCLE_SHORT_SHA1 = $env:CIRCLE_SHA1.substring(0,7) | ||
$BUILD_FILE_NAME = "staking_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
$BUILD_FILE_NAME = "ethstaker_deposit-cli-" + $CIRCLE_SHORT_SHA1 + "-windows-amd64" | ||
$BUILD_FILE_NAME_PATH = ".\" + $BUILD_FILE_NAME | ||
$ZIP_FILE_NAME = $BUILD_FILE_NAME + ".zip" | ||
Compress-Archive -Path $BUILD_FILE_NAME_PATH -DestinationPath $ZIP_FILE_NAME | ||
|
@@ -256,15 +256,15 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
mkdir ${BUILD_FILE_NAME}; | ||
pyinstaller --distpath ./${BUILD_FILE_NAME} ./build_configs/macos/build.spec; | ||
- run: | ||
name: Test executable binaries | ||
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
export TEST_FOLDER_NAME=TMP_TEST_FOLDER | ||
mkdir ${TEST_FOLDER_NAME} | ||
cp -r ${BUILD_FILE_NAME} ${TEST_FOLDER_NAME} | ||
|
@@ -278,7 +278,7 @@ jobs: | |
command: | | ||
export PYTHONHASHSEED=42 | ||
export CIRCLE_SHORT_SHA1=$(eval echo $CIRCLE_SHA1 | cut -c -7) | ||
export BUILD_FILE_NAME=staking_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
export BUILD_FILE_NAME=ethstaker_deposit-cli-${CIRCLE_SHORT_SHA1}-darwin-amd64; | ||
tar -zcvf ${BUILD_FILE_NAME}.tar.gz ./${BUILD_FILE_NAME}; | ||
mkdir /tmp/artifacts; | ||
cp ${BUILD_FILE_NAME}.tar.gz /tmp/artifacts; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
# staking-deposit-cli | ||
|
||
[![GitPOAP Badge](https://public-api.gitpoap.io/v1/repo/ethereum/staking-deposit-cli/badge)](https://www.gitpoap.io/gh/ethereum/staking-deposit-cli) | ||
# ethstaker-deposit-cli | ||
|
||
<!-- START doctoc generated TOC please keep comment here to allow auto update --> | ||
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | ||
|
@@ -102,7 +100,7 @@ On Unix-based systems, keystores and the `deposit_data*.json` have `440`/`-r--r- | |
|
||
##### Step 1. Installation | ||
|
||
See [releases page](https://github.com/ethereum/staking-deposit-cli/releases) to download and decompress the corresponding binary files. | ||
See [releases page](https://github.com/eth-educators/ethstaker-deposit-cli/releases) to download and decompress the corresponding binary files. | ||
|
||
##### Step 2. Create keys and `deposit_data-*.json` | ||
|
||
|
@@ -332,23 +330,23 @@ pip3 install -r requirements.txt | |
Run one of the following command to enter the interactive CLI: | ||
|
||
```sh | ||
python3 -m staking_deposit new-mnemonic | ||
python3 -m ethstaker_deposit new-mnemonic | ||
``` | ||
|
||
or | ||
|
||
```sh | ||
python3 -m staking_deposit existing-mnemonic | ||
python3 -m ethstaker_deposit existing-mnemonic | ||
``` | ||
|
||
You can also run the tool with optional arguments: | ||
|
||
```sh | ||
python3 -m staking_deposit new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
python3 -m ethstaker_deposit new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
``` | ||
|
||
```sh | ||
python3 -m staking_deposit existing-mnemonic --num_validators=<NUM_VALIDATORS> --validator_start_index=<START_INDEX> --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
python3 -m ethstaker_deposit existing-mnemonic --num_validators=<NUM_VALIDATORS> --validator_start_index=<START_INDEX> --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
``` | ||
|
||
###### Language Argument | ||
|
@@ -382,19 +380,19 @@ make build_docker | |
Run the following command to enter the interactive CLI: | ||
|
||
```sh | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli | ||
``` | ||
|
||
You can also run the tool with optional arguments: | ||
|
||
```sh | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --folder=<YOUR_FOLDER_PATH> | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --folder=<YOUR_FOLDER_PATH> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the image name needs to be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ack |
||
``` | ||
|
||
Example for 1 validator on the [Prater testnet](https://prater.launchpad.ethereum.org/) using english: | ||
|
||
```sh | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli new-mnemonic --num_validators=1 --mnemonic_language=english --chain=prater | ||
docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli new-mnemonic --num_validators=1 --mnemonic_language=english --chain=prater | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the image name needs to be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ack |
||
``` | ||
|
||
###### Arguments | ||
|
@@ -411,7 +409,7 @@ See [here](#successful-message) | |
|
||
##### Step 1. Installation | ||
|
||
See [releases page](https://github.com/ethereum/staking-deposit-cli/releases) to download and decompress the corresponding binary files. | ||
See [releases page](https://github.com/eth-educators/ethstaker-deposit-cli/releases) to download and decompress the corresponding binary files. | ||
|
||
##### Step 2. Create keys and `deposit_data-*.json` | ||
|
||
|
@@ -546,23 +544,23 @@ pip3 install -r requirements.txt | |
Run one of the following command to enter the interactive CLI: | ||
|
||
```cmd | ||
python -m staking_deposit new-mnemonic | ||
python -m ethstaker_deposit new-mnemonic | ||
``` | ||
|
||
or | ||
|
||
```cmd | ||
python -m staking_deposit existing-mnemonic | ||
python -m ethstaker_deposit existing-mnemonic | ||
``` | ||
|
||
You can also run the tool with optional arguments: | ||
|
||
```cmd | ||
python -m staking_deposit new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
python -m ethstaker_deposit new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
``` | ||
|
||
```cmd | ||
python -m staking_deposit existing-mnemonic --num_validators=<NUM_VALIDATORS> --validator_start_index=<START_INDEX> --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
python -m ethstaker_deposit existing-mnemonic --num_validators=<NUM_VALIDATORS> --validator_start_index=<START_INDEX> --chain=<CHAIN_NAME> --folder=<YOUR_FOLDER_PATH> | ||
``` | ||
|
||
###### Language Argument | ||
|
@@ -604,7 +602,7 @@ python3 -m pytest tests | |
### Run the app | ||
|
||
```sh | ||
python3 -m staking_deposit [OPTIONS] COMMAND [ARGS] | ||
python3 -m ethstaker_deposit [OPTIONS] COMMAND [ARGS] | ||
``` | ||
|
||
### Building Binaries | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the image name needs to be
eth-educators/ethstaker-deposit-cli
(from the newDOCKER_IMAGE
in Makefile). This will need more tests from #61 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack