New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove globals from core to improve usage as a library #99

Open

tstromberg wants to merge 4 commits into eth0izzle:master from tstromberg:master

tstromberg commented Mar 25, 2022

This PR addresses some embedding issues I experienced with the core library:

Global sessions made it difficult to process multiple repositories simultaneous
Global flags made it equally difficult to have multiple configurations simultaneously
Hardcoded config.yaml name felt awkward (For instance, I prefer sshgit.yaml).

Please let me know if there are any improvements you would like me to make. Thanks for the excellent tool & library!

tstromberg added 4 commits

March 24, 2022 16:38


          Add NewSession, make options easier to embed

4d380a6


          Remove remaining session/flag globals

87bdc00


          Address remaining embed issues

eb6f81d


          Add StringSubMatches

14ba1d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet