Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested mod folders #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

stupxd
Copy link

@stupxd stupxd commented Aug 31, 2024

Seems to be the way things are heading /shrug

@stupxd stupxd changed the title Support nested mod folders with .lovelynested Support nested mod folders Sep 4, 2024
@flakywanderer
Copy link
Contributor

This is something I meant to say earlier but forgot until now

My idea for the syntax for directory inclusions was something more like an include patch, like this:

[[patches.include]]
files = [
    "foo/bar.toml",
    "foo/baz.toml"
]
directories = [
    "xyzzy",
    "zzyzx"
]

@ethangreen-dev
Copy link
Owner

I think making nested directories data-oriented is the right approach, but I don't like making it another "patch". The right way to go about this is to standardize some sort of "lovely manifest", which would contain this information instead.

The lovely manifest is the big reason why this PR has not yet been reviewed - quite simply because it doesn't exist yet. I'll give this the review and merge it deserves once we're at a point where we have a design finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants