Feature/741 b prisma transactions #779
Conversation
…torage agents, deletes storage agent extension of prismaService.
…nd converts POC prisma actions into prisma promises within respective storage agents
…and accept and await spread operator operations
…torage agents, and make sure of closures in passing arguments to prisma service execute transaction
Kasshern
requested review from
skarred14,
ognjenkurtic,
Therecanbeonlyone1969,
Ybittan,
biscuitdey and
skosito
as code owners
…torage agents, deletes storage agent extension of prismaService.
…nd converts POC prisma actions into prisma promises within respective storage agents
…and accept and await spread operator operations
…torage agents, and make sure of closures in passing arguments to prisma service execute transaction
…/eea-oasis/baseline into feature/741B-prisma-transactions
…lowcommandhandler
| bpiAccountCandidate: BpiAccount, | ||
| workflowCandidate: Workflow, | ||
| ): Promise<any> { | ||
| const boundStoreNewWorkflow = this.storeNewWorkflow.bind(this); |
| this.bpiAccountStorageAgent.storeNewBpiAccount.bind( | ||
| this.bpiAccountStorageAgent, | ||
| ); | ||
| const results = await this.prisma.executeTransaction(() => { |
There was a problem hiding this comment.
you are still passing only one operation here, so not quite showing array of sequential operations, it should be array [storeBpiAccount, storeWorkflow], not storeBpiAccount.then(storeWorkflow)? this way it seems we are controlling this execution, and prisma should sequentially execute all or nothing behind the scenes if i understand correctly
| @@ -49,14 +53,14 @@ export class WorkflowStorageAgent { | |||
| }); | |||
| } | |||
|
|
|||
| async storeNewWorkflow(workflow: Workflow): Promise<Workflow> { | |||
| storeNewWorkflow(workflow: Workflow): PrismaPromise<WorkflowModel> { | |||
There was a problem hiding this comment.
not sure i understand changes to this method, could you please add more details?
| return await this.$transaction(async () => { | ||
| const results: any[] = []; | ||
| for (const operation of operations) { | ||
| results.push(await operation()); |
There was a problem hiding this comment.
do we need to await operations?
|
@Kasshern could we go through this in detail on Monday? would like to get a walk through to be able to better understand some of the decisions made. Or provide async here a little more details please explaining the implementation decisions |
|
Agreement is to stick with the simple nested query approach for now in few places where we care about transactions until we find a better way to solve this |
|
Core Dev 02/05/24 - This PR will be replaced with a more simple implementation. |
Description
Implements prototype for prisma service atomic execution of db operations.
Related Issue
SRI - Introduce Prisma Transactions #741
Motivation and Context
links Db operations atomically
How Has This Been Tested
tests forthcoming
Screenshots (if appropriate)
Types of changes
Checklist