Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Prisma Nested Write - Workflow Creation #787

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Introduce Prisma Nested Write - Workflow Creation #787

merged 1 commit into from
Feb 28, 2024

Conversation

Kasshern
Copy link
Collaborator

@Kasshern Kasshern commented Feb 8, 2024 •
edited
Loading

updates create workflow to nested write of create BpiAccount and Workflow

Description

updates the workflow creation flow so that a nested write is used to atomically create the BpiAccount and associated Workflow within the BPI

Related Issue

#741

Motivation and Context

introduces first example of atomic changes to multiple records within the db

How Has This Been Tested

forthcoming

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @ognjenkurtic @biscuitdey @skosito

biscuitdey
biscuitdey approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@biscuitdey biscuitdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ognjenkurtic ognjenkurtic merged commit 57cea4b into main Feb 28, 2024
1 of 2 checks passed
@ognjenkurtic ognjenkurtic deleted the feature/741C-prisma-transactions branch February 28, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@biscuitdey biscuitdey biscuitdey approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14 skarred14 is a code owner

@ognjenkurtic ognjenkurtic Awaiting requested review from ognjenkurtic ognjenkurtic is a code owner

@Ybittan Ybittan Awaiting requested review from Ybittan Ybittan is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kasshern @biscuitdey @Therecanbeonlyone1969 @ognjenkurtic