Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

fix: Check for overflows in safety checker #377

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Check for overflows in safety checker #377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c5b0d
fix: Check for overflows in safety checker
smartcontracts Apr 9, 2021
3fd4b68
Merge branch 'master' into fix/safety-checker-overflow
smartcontracts Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions contracts/optimistic-ethereum/OVM/execution/OVM_SafetyChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,17 @@ contract OVM_SafetyChecker is iOVM_SafetyChecker {
// PUSH opcodes
uint256 opcodePushMask = ~uint256(0xffffffff000000000000000000000000);

uint256 codeLength;
uint256 _pc;
assembly {
_pc := add(_bytecode, 0x20)
}
codeLength = _pc + _bytecode.length;
uint256 codeLength = _pc + _bytecode.length;

// Simple overflow check.
if (codeLength < _pc) {
return false;
}

do {
// current opcode: 0x00...0xff
uint256 opNum;
Expand Down