Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling beta #1124

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Handling beta #1124

wants to merge 5 commits into from

Conversation

brokewhale
Copy link
Contributor

@brokewhale brokewhale commented Nov 18, 2024

https://github.com/orgs/ethereum-optimism/projects/40/views/11?sliceBy%5Bvalue%5D=brokewhale&pane=issue&itemId=83945211&issue=ethereum-optimism%7Cdevrel%7C383

Added overview to the beta features section

Beta features

We can still answer and support beta features but for deeper issues:

  • Create a new section under the OP Stack docs, call the subsection "Beta Features"
  • Move all the current beta feature documentation under that section
  • Add an overview page that references these pages and describes what beta features mean
  • Add a note that an issue should be logged to the monorepo if any bugs are found
  • Add redirects

https://www.notion.so/oplabs/Beta-Feature-Rollout-Alignment-1-Pager-May-2024-1b72acadaa5e45e0892fd9a6d54e3c1f#b1b049564ecd4501bac29e9897d4b931

@brokewhale brokewhale requested a review from a team as a code owner November 18, 2024 13:44
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 8c5a2bc
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/6745b42b0dd55b0008342d84
😎 Deploy Preview https://deploy-preview-1124--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 18, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces significant revisions to the documentation for the "Beta Features" section of the OP Stack ecosystem. It shifts the focus from specific features like "Alt Da Mode" and "Custom Gas Token" to a broader overview of beta features, emphasizing their benefits and the feedback process. A new warning callout is included at the beginning to inform users that all features are in beta and may change.

The introduction has been expanded to welcome users and clarify the purpose of beta features, highlighting their role in gathering feedback for tool refinement. New sections titled "What Are Beta Features?" and "Benefits of Using Beta Features?" have been added to explain the advantages of early access and the importance of user feedback. A "Key Considerations" section advises users about potential bugs and limited support during the testing phase.

The documentation also details the feedback process, guiding users on how to document experiences and report issues. Additionally, the list of available beta features has been updated, removing the term "explainer" from the titles of "Alt-DA Mode" and "Custom Gas Token," while enhancing visual elements with icons.

In the accompanying JSON file, minor formatting changes were made to align with JSON standards, specifically the indentation of certain keys.

Possibly related PRs

  • Add alt-da mode docs #752: This PR adds documentation for "Alt-DA Mode," which is directly related to the changes in the main PR that discuss beta features, including "Alt-DA Mode."
  • Rename Plasma to Alt-da, Add Breaking Changes #886: This PR updates documentation regarding the transition from Plasma to Alt-DA, which aligns with the main PR's focus on beta features and their implications.
  • altda: soften beta warning wording #900: This PR softens the beta warning wording for the Alt-DA feature, which is relevant to the main PR's emphasis on beta features and user feedback.
  • updating notice to have info on breaking changes #889: This PR adds information about breaking changes related to the Alt-DA mode, which connects to the main PR's updates on beta features and user guidance.
  • Update rollup.mdx #1127: This PR updates the rollup configuration documentation, which may relate to the broader context of beta features and their configurations discussed in the main PR.

Suggested labels

flag:merge-pending-release

Suggested reviewers

  • sbvegan
  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)
pages/stack/beta-features.mdx (2)

9-11: Enhance the warning message clarity and formatting.

Consider these improvements:

  1. Remove the bold formatting and use more direct language
  2. Be more specific instead of using "here"
<Callout type="warning">
-  **Note:** All features listed here are currently in beta and under active development. Expect changes in functionality, design, and performance as we gather feedback and make improvements.
+  Note: All features in this section are currently in beta and under active development. Expect changes in functionality, design, and performance as we gather feedback and make improvements.
</Callout>

49-54: Enhance card accessibility and visual distinction.

Consider these improvements:

  1. Add unique icons for each feature to help with visual distinction
  2. Include alt text for the icons to improve accessibility
  <Card 
    title="Alt-DA Mode" 
    href="/stack/beta-features/alt-da-mode" 
-   icon={<img src="/img/icons/shapes.svg" />} 
+   icon={<img src="/img/icons/alt-da.svg" alt="Alt-DA Mode icon" />}
  />

  <Card 
    title="Custom Gas Token" 
    href="/stack/beta-features/custom-gas-token" 
-   icon={<img src="/img/icons/shapes.svg" />}
+   icon={<img src="/img/icons/gas-token.svg" alt="Custom Gas Token icon" />}
  />
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 13c482f and b15d61a.

📒 Files selected for processing (2)
  • pages/stack/beta-features.mdx (1 hunks)
  • pages/stack/beta-features/_meta.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/stack/beta-features/_meta.json
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/beta-features.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (2)
pages/stack/beta-features.mdx (2)

1-5: LGTM! Frontmatter follows documentation guidelines.

The title and description are properly formatted with correct capitalization and neutral language.


6-8: LGTM! Component imports are properly structured.

pages/stack/beta-features.mdx Outdated Show resolved Hide resolved
pages/stack/beta-features.mdx Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
pages/stack/beta-features.mdx (1)

15-17: Enhance clarity and directness in the overview section.

The overview can be more concise and direct.

Consider this revision:

- Welcome to the Beta Features overview. This section contains a list of the latest in-development features currently in the beta stage. Beta features are available for early access and feedback gathering, helping to refine and optimize these tools before a full release.
+ Welcome to the Beta Features overview. This section lists the latest in-development features in beta stage. Beta features provide early access and gather feedback to optimize tools before full release.

- These features may undergo changes based on user feedback and ongoing improvements. The functionality and design may evolve. Explore the sections below for more information on individual beta features and participation in shaping their final release.
+ These features may change based on feedback and improvements. Explore the sections below to learn about individual beta features and contribute to their development.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b15d61a and f209931.

📒 Files selected for processing (1)
  • pages/stack/beta-features.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/beta-features.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (1)
pages/stack/beta-features.mdx (1)

49-52: LGTM!

The Cards section is well-structured with consistent formatting and proper icon usage.

Comment on lines +25 to +27
* **Early access**: Be among the first to use the latest innovations.
* **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
* **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix capitalization and remove personal pronouns.

There are inconsistencies in capitalization and a remaining personal pronoun.

Apply these changes:

- *   **Early access**: Be among the first to use the latest innovations.
- *   **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
- *   **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
+ *   **Early access**: Be among the first to use the latest innovations.
+ *   **Influence development**: Your feedback plays a critical role in refining and optimizing these features.
+ *   **Enhanced product understanding**: Working with beta features provides insights into the future direction of the product and its evolution.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* **Early access**: Be among the first to use the latest innovations.
* **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
* **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
* **Early access**: Be among the first to use the latest innovations.
* **Influence development**: Your feedback plays a critical role in refining and optimizing these features.
* **Enhanced product understanding**: Working with beta features provides insights into the future direction of the product and its evolution.

pages/stack/beta-features.mdx Outdated Show resolved Hide resolved
pages/stack/beta-features.mdx Outdated Show resolved Hide resolved
Comment on lines 15 to 16
Welcome to the Beta Features overview. This section contains a list of the latest in-development features currently in the beta stage. Beta features are available for early access and feedback gathering, helping to refine and optimize these tools before a full release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Welcome to the Beta Features overview. This section contains a list of the latest in-development features currently in the beta stage. Beta features are available for early access and feedback gathering, helping to refine and optimize these tools before a full release.
Welcome to the beta features overview. This section contains a list of the latest in-development features currently in the beta stage. Beta features are available for early access and feedback gathering, helping to refine and optimize these tools before a full release.

pages/stack/beta-features.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (1)
pages/stack/beta-features.mdx (1)

53-61: Consider using distinct icons for different features.

Currently, both features use the same icon (shapes.svg). Using unique icons would help users visually distinguish between different beta features.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f209931 and 8c5a2bc.

📒 Files selected for processing (2)
  • next-env.d.ts (1 hunks)
  • pages/stack/beta-features.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • next-env.d.ts
🧰 Additional context used
📓 Path-based instructions (1)
pages/stack/beta-features.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
pages/stack/beta-features.mdx

[uncategorized] ~45-~45: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ial Channels**: Submit feedback and bug report through the optimism [monorepo](https:/...

(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)

🔇 Additional comments (1)
pages/stack/beta-features.mdx (1)

10-14: LGTM! Well-structured warning callout.

The warning callout effectively communicates the beta status and sets appropriate expectations.

@@ -1,17 +1,63 @@
---
title: Beta Features
description: Documentation covering Alt Da Mode, Custom Gas Token in the Beta Features section of the OP Stack ecosystem.
description: Learn how beta features in the OP Stack works, their benefits, and how to provide feedbacks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammatical errors in the description.

The description contains two grammatical errors:

  1. Subject-verb agreement: "features... works" should be "features... work"
  2. "feedbacks" should be "feedback" (uncountable noun)
-description: Learn how beta features in the OP Stack works, their benefits, and how to provide feedbacks.
+description: Learn how beta features in the OP Stack work, their benefits, and how to provide feedback.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
description: Learn how beta features in the OP Stack works, their benefits, and how to provide feedbacks.
description: Learn how beta features in the OP Stack work, their benefits, and how to provide feedback.

Comment on lines +29 to +30
* **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
* **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Apply sentence case to benefit headings.

According to the documentation guidelines, headings should use sentence case.

-*   **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
-*   **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
+*   **Influence development**: Your feedback plays a critical role in refining and optimizing these features.
+*   **Enhanced product understanding**: Working with beta features provides insights into the future direction of the product and its evolution.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* **Influence Development**: Your feedback plays a critical role in helping us refine and optimize these features.
* **Enhanced Product Understanding**: Working with beta features can provide insights into the future direction of our product and how it will evolve.
* **Influence development**: Your feedback plays a critical role in refining and optimizing these features.
* **Enhanced product understanding**: Working with beta features provides insights into the future direction of the product and its evolution.

Comment on lines +44 to +46
1. **Document Your Experience**: Take note of any issues, suggestions, or enhancements you'd like to see.
2. **Report Through Official Channels**: Submit feedback and bug report through the optimism [monorepo](https://github.com/ethereum-optimism/optimism/issues).
3. **Participate in Surveys**: Occasionally, we'll send surveys to beta users. Participating in these helps us prioritize improvements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammar and remove personal pronouns.

There are several issues in this section:

  1. "bug report" should be "bug reports" (plural)
  2. Remove personal pronoun "we'll"
  3. The Optimism monorepo link should be properly capitalized
-1.  **Document Your Experience**: Take note of any issues, suggestions, or enhancements you'd like to see.
-2.  **Report Through Official Channels**: Submit feedback and bug report through the optimism [monorepo](https://github.com/ethereum-optimism/optimism/issues).
-3.  **Participate in Surveys**: Occasionally, we'll send surveys to beta users. Participating in these helps us prioritize improvements.
+1.  **Document your experience**: Take note of any issues, suggestions, or enhancements you'd like to see.
+2.  **Report through official channels**: Submit feedback and bug reports through the [Optimism monorepo](https://github.com/ethereum-optimism/optimism/issues).
+3.  **Participate in surveys**: Occasionally, surveys will be sent to beta users. Survey participation helps prioritize improvements.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. **Document Your Experience**: Take note of any issues, suggestions, or enhancements you'd like to see.
2. **Report Through Official Channels**: Submit feedback and bug report through the optimism [monorepo](https://github.com/ethereum-optimism/optimism/issues).
3. **Participate in Surveys**: Occasionally, we'll send surveys to beta users. Participating in these helps us prioritize improvements.
1. **Document your experience**: Take note of any issues, suggestions, or enhancements you'd like to see.
2. **Report through official channels**: Submit feedback and bug reports through the [Optimism monorepo](https://github.com/ethereum-optimism/optimism/issues).
3. **Participate in surveys**: Occasionally, surveys will be sent to beta users. Survey participation helps prioritize improvements.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~45-~45: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...ial Channels**: Submit feedback and bug report through the optimism [monorepo](https:/...

(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants