This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
dev: Revert ethash changes #266
Open
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
suggested changes
Mar 19, 2021
|
|
||
| if uint64(diff) >= limit || header.GasLimit < params.MinGasLimit { |
There was a problem hiding this comment.
This causes the TestChainTxReorgs because header.GasLimit < params.MinGasLimit (the MinGasLimit = 4m, whereas the gas limit used in the provided header is 3.4m). The blockchain_test.go and ethash/consensus.go are the same as c49a4165d074c2d08c362cfe1dac835b6a3e1251, so I am not sure why this happens.
The TestGenerateBlockAndImportEthash test also fails at the timestamp check in consensus.go:257, because both the header.Time and parent.Time are 0. Similarly, I would have expected that there is some time given until the next block is passed.
Despite the fact that these test cases may not be part of the "normal" codepaths, it seems like we should understand why these fail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting some unused changes to
ethash.go.Metadata
Fixes
Contributing Agreement