This repository has been archived by the owner on Apr 11, 2021. It is now read-only.
Add first pass change to tx rejection #299
Draft
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we could move those changes to here: go-ethereum/eth/api_backend.go Line 294 in 79c1dc1 |
|
@smartcontracts when you get to this point @tynes has the great suggestion to move these checks into the backend |
ben-chain
reviewed
Apr 6, 2021
| @@ -558,6 +560,14 @@ func (pool *TxPool) validateTx(tx *types.Transaction, local bool) error { | |||
| // Transactor should have enough funds to cover the costs | |||
| // cost == V + GP * GL | |||
| if vm.UsingOVM { | |||
| // TODO: Update syntax to add rejection logic | |||
There was a problem hiding this comment.
Make sure to check for overflows in this logic when implementing!
|
@karlfloersch What feature/fix is this PR implementing? |
Ah this was part of adding fees. @smartcontracts do we have tx rejection logic? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first pass WIP that is just missing the correct imports / syntax
Metadata
Fixes
Contributing Agreement