Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): op-acceptor error handling refactor #257

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

scharissis
Copy link
Contributor

Description

Slight refactor addressing some unresolved comments from a previous PR (#254)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.70%. Comparing base (ddca10c) to head (2f66740).

Files with missing lines Patch % Lines
op-acceptor/nat.go 0.00% 5 Missing ⚠️
op-acceptor/runner/runner.go 89.65% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   53.63%   53.70%   +0.06%     
==========================================
  Files          67       67              
  Lines        7881     7901      +20     
==========================================
+ Hits         4227     4243      +16     
- Misses       3373     3377       +4     
  Partials      281      281              
Flag Coverage Δ
op-acceptor 55.01% <76.47%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-acceptor/runner/runner.go 69.21% <89.65%> (+0.46%) ⬆️
op-acceptor/nat.go 40.79% <0.00%> (-0.24%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scharissis scharissis merged commit 2737e70 into main Mar 24, 2025
6 checks passed
@scharissis scharissis deleted the scharissis/op-acceptor/refactor-error-logging branch March 24, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants