Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Kurtosis-specific go job #13249

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

mslipper
Copy link
Collaborator

@mslipper mslipper commented Dec 4, 2024

Kurtosis landed my fix for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back.

Kurtosis landed [my fix](kurtosis-tech/kurtosis#2567) for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back.
@mslipper mslipper requested a review from a team as a code owner December 4, 2024 23:50
@mslipper mslipper requested a review from ajsutton December 4, 2024 23:50
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (d3fbc57) to head (8dbb632).
Report is 1 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (d3fbc57) and HEAD (8dbb632). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d3fbc57) HEAD (8dbb632)
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13249       +/-   ##
============================================
- Coverage    64.58%   44.55%   -20.04%     
============================================
  Files          175      810      +635     
  Lines        11535    72680    +61145     
  Branches      1133        0     -1133     
============================================
+ Hits          7450    32380    +24930     
- Misses        3830    37653    +33823     
- Partials       255     2647     +2392     
Flag Coverage Δ
cannon-go-tests-32 61.85% <ø> (ø)
cannon-go-tests-64 56.72% <ø> (ø)
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 873 files with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Dec 5, 2024
Merged via the queue into develop with commit 139dabe Dec 5, 2024
44 checks passed
@mslipper mslipper deleted the feat/remove-kurtosis-specific-jobs branch December 5, 2024 00:08
sigma pushed a commit that referenced this pull request Dec 19, 2024
* ci: Remove Kurtosis-specific go job

Kurtosis landed [my fix](kurtosis-tech/kurtosis#2567) for the race condition that prevented us from running a shared Kurtosis instance between jobs. This PR brings that back.

* remove dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants