Rename SHARD_COMMITTEE_PERIOD #3942
Open
+103
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames SHARD_COMMITTEE_PERIOD to MIN_VALIDATOR_ACTIVE_PERIOD. Since we don't have shard committees anymore, naming things after shard committees doesn't make sense. This commit renames it to MIN_VALIDATOR_ACTIVE_PERIOD so that it means the minimum period that the validator has to be active before exiting.
|
It's hard to change the phase0 configuration now without solid reasons. 😅 I'd leave this PR open for a while. /cc @dankrad on thoughts of naming for FullDAS. |
dapplion
reviewed
Oct 2, 2024
| @@ -72,7 +72,7 @@ SECONDS_PER_ETH1_BLOCK: 14 | |||
| # 2**8 (= 256) epochs ~27 hours | |||
| MIN_VALIDATOR_WITHDRAWABILITY_DELAY: 256 | |||
| # 2**8 (= 256) epochs ~27 hours | |||
| SHARD_COMMITTEE_PERIOD: 256 | |||
| MIN_VALIDATOR_ACTIVE_PERIOD: 256 | |||
There was a problem hiding this comment.
This is a breaking change and can mess up clients that expect this key to exist in configs. If we merge this, client binaries will have to either:
- Update their expect config name, work with spec tests, break with existing user configs
- Not update, break with spec tests and work with existing user configs
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames SHARD_COMMITTEE_PERIOD to MIN_VALIDATOR_ACTIVE_PERIOD. Since we don't have shard committees anymore, naming things after shard committees doesn't make sense. This PR renames it to MIN_VALIDATOR_ACTIVE_PERIOD so that it means the minimum period that the validator has to be active before exiting.