execution-apis: Add EIP-7594 (PeerDAS) related changes #630
Conversation
Co-authored-by: fradamt <[email protected]>
Co-authored-by: fradamt <[email protected]>
Co-authored-by: Tei Im <[email protected]>
Co-authored-by: Tei Im <[email protected]>
fix camel case and other small changes
**Motivation** add `engine_getBlobsV2` to the execution API in preparation for implementation of [distributed blob publishing](https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#distributed-blob-publishing-using-blobs-retrieved-from-local-execution-layer-client) @dguenther and I wanted to get early feedback on the API change before moving forward with the rest of the implementation **Description** upcoming spec changes will add `engine_getBlobsV2` to the execution API to fetch blobs and cell proofs from the execution layer (ethereum/execution-apis#630) * add `engine_getBlobsV2` to execution API * add type definition for `BlobAndProofV2` **Not included** We'll follow up with additional PR(s) for these as we move forward with distributed blob publishing: * fetch blobs from the EL in two places: on first seen block input gossip and on unknown blocks during syncing * reconstruct blobs from cell proofs * publish data column sidecars on subscribed topics after Relates to #7638 --------- Co-authored-by: Derek Guenther <[email protected]>
0x00101010
changed the title
|
|
||
| Refer to the specification for [`engine_getBlobsV1`](./cancun.md#engine_getblobsv1) with changes of the following: | ||
|
|
||
| 1. Given an array of blob versioned hashes client software **MUST** respond with an array of `BlobAndProofV2` objects with matching versioned hashes, respecting the order of versioned hashes in the input array. |
There was a problem hiding this comment.
Should there be any information about how old transactions are handled by this method?
There was a problem hiding this comment.
It is specified here: https://github.com/ethereum/execution-apis/pull/630/files#diff-3a9e53de4a77d1ceec28870b24b0ff6e8f89437ae2d439aab70a75990060736dR35-R40
The idea is that old txs should've already been converted to new format or dropped already (which won't be included in the block)
|
|
||
| Engine API changes introduced in Osaka. | ||
|
|
||
| This specification is based on and extends [Engine API - Prague](./prague.md) specification. |
There was a problem hiding this comment.
When new versions of methods are introduced there is usually a statement on how to limit the scope of the previous versions. I think this doc should at least add modification to engine_getPayloadV4 while engine_getBlobsV2 is a bit more tricky in that regard, see https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#update-the-methods-of-previous-forks.
There was a problem hiding this comment.
Great callout, added update-the-methods-of-previous-forks section for engine_getblobsv1.
As for getPayloadV4, previous section already specifies the validation should reject anything that's older than Prague, so it covers Osaka.
Summary
Introduces updates to rpc and engine API definitions for EIP-7594, changes defined in ethereum/EIPs#9378
Notes for reviewers
This PR introduces backward incompatible changes to
engine_getPayloadV4, that returns newBlobsBundleV2with cell proofs instead of blob proofs