Appease clippy's new rules #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahscopes
force-pushed
the
fix-lifetime-elision-lint
branch
2 times, most recently
from
8ceb15d
to
d6c0f71
Compare
micahscopes
force-pushed
the
fix-lifetime-elision-lint
branch
from
d6c0f71
to
d400186
Compare
micahscopes
changed the title
micahscopes
commented
Nov 30, 2024
| @@ -306,58 +358,6 @@ impl<'db> TyCheckerFinalizer<'db> { | |||
| } | |||
|
|
|||
| fn check_unknown_types(&mut self) { | |||
| impl<'db> Visitor<'db> for TyCheckerFinalizer<'db> { | |||
There was a problem hiding this comment.
Clippy didn't like this trait being implemented inside of this function.
| ) { | ||
| (reason, output) | ||
| } else { | ||
| panic!("EVM trap during test") |
There was a problem hiding this comment.
Clippy complained that this else block never gets reached and that the surrounding if let was unnecessary
| @@ -110,6 +110,7 @@ impl<'db> ModuleTree<'db> { | |||
| /// top level modules. This function only depends on an ingot structure and | |||
| /// external ingot dependency, and not depends on file contents. | |||
| #[salsa::tracked(return_ref)] | |||
| #[allow(elided_named_lifetimes)] | |||
There was a problem hiding this comment.
Clippy and the rust compiler were battling back and forth, on the one hand Clippy would complain about needless_lifetimes and change it to the elided version, but then the rust compiler would complain about elided_named_lifetimes. So I added this allow rule here and one other place.
| @@ -117,6 +117,7 @@ impl<'db> ModuleAnalysisPass<'db> for ParsingPass<'db> { | |||
| // The reason why this function is not a public API is that we want to prohibit users of `HirDb` to | |||
| // access `InputIngot` directly. | |||
| #[salsa::tracked(return_ref)] | |||
| #[allow(elided_named_lifetimes)] | |||
There was a problem hiding this comment.
another place where clippy was battling the compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Clippy has been complaining about unnecessary explicit lifetimes. In order to please clippy I found that I had to fix quite a few other things as well.
I'm not sure that they're actually unnecessary though: rust-lang/rust-clippy#12908I'm opening this PR to find out.How was it fixed?
clippy --fix ...